[patch] no-redundandant-roles: allow <img src="*.svg" role="img" /> #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Setting role="img" is a valid use case to work around a Safari bug for better accessibility when the source image is an SVG file. This improvement does not account for variables in the `src` attribute but adds a valid exception for when we can parse the string. Fixes jsx-eslint#936
lb- force-pushed the feature/936-role-img-svg-src branch from 8c64e25 to 0942f4d Compare 
ljharb approved these changes Oct 25, 2024
ljharb force-pushed the feature/936-role-img-svg-src branch 2 times, most recently from 4495c4c to fa9845d Compare ljharb changed the title <img src="*.svg" role="img" />no-redundandant-roles: allow <img src="*.svg" role="img" /> ljharb changed the title no-redundandant-roles: allow <img src="*.svg" role="img" /> no-redundandant-roles: allow <img src="*.svg" role="img" /> 
| Thanks @ljharb |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Setting role="img" is a valid use case to work around a Safari bug for better accessibility when the source image is an SVG file.
This improvement does not account for variables in the
srcattribute but adds a valid exception for when we can parse the string. In addition, add validaria-roletest for<svg role="img" />to ensure no future conflicts arise.Closes #936