Skip to content

Fixed angular element children selector usage #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed angular element children selector usage #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed angular element children selector usage
  • Loading branch information
@aklinkert
aklinkert committed Nov 24, 2015
commit b3692cfddcaee2f7fc7c8bcc683703c07370ae8f
7 changes: 6 additions & 1 deletion dist/schema-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2609,7 +2609,12 @@ angular.module('schemaForm')
childScope.schemaForm = {form: merged, schema: schema};

//clean all but pre existing html.
element.children(':not(.schema-form-ignore)').remove();
// use vanillajs api to identify elements to delete
Array.prototype.forEach.call(element[0].children, function(child) {
if (([' ', child.className, ' '].join('')).indexOf(' schema-form-ignore ') === -1 && child.querySelectorAll('[sf-insert-field]').length === 0) {
angular.element(child).remove();
}
});

// Find all slots.
var slots = {};
Expand Down
Loading