Skip to content

Commit 6cfaf2b

Browse files
barancevbarancev
committed
Unignoring tests that pass locally in Chrome
1 parent b99e016 commit 6cfaf2b

11 files changed

+22
-34
lines changed

‎java/client/test/org/openqa/selenium/ClearTest.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,12 @@
2323
import static org.junit.Assert.assertEquals;
2424
import static org.junit.Assert.fail;
2525
import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
26-
import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
2726
import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
2827
import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
2928
import static org.openqa.selenium.testing.Ignore.Driver.OPERA_MOBILE;
3029
import static org.openqa.selenium.testing.Ignore.Driver.SELENESE;
3130

32-
@Ignore({CHROME, SELENESE, ANDROID})
31+
@Ignore({SELENESE, ANDROID})
3332
public class ClearTest extends JUnit4TestBase {
3433

3534
@Test

‎java/client/test/org/openqa/selenium/ClickScrollingTest.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ public void testShouldScrollToClickOnAnElementHiddenByOverflow() {
8181
}
8282

8383
@Test
84-
@Ignore(CHROME)
8584
public void testShouldBeAbleToClickOnAnElementHiddenByOverflow() {
8685
driver.get(appServer.whereIs("scroll.html"));
8786

@@ -91,7 +90,7 @@ public void testShouldBeAbleToClickOnAnElementHiddenByOverflow() {
9190
assertEquals("line8", driver.findElement(By.id("clicked")).getText());
9291
}
9392

94-
@Ignore({CHROME, OPERA, SELENESE})
93+
@Ignore({OPERA, SELENESE})
9594
@Test
9695
public void testShouldNotScrollOverflowElementsWhichAreVisible() {
9796
driver.get(appServer.whereIs("scroll2.html"));

‎java/client/test/org/openqa/selenium/ElementAttributeTest.java‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
import static org.junit.Assert.assertTrue;
3636
import static org.junit.Assert.fail;
3737
import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
38-
import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
3938
import static org.openqa.selenium.testing.Ignore.Driver.IE;
4039
import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
4140
import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
@@ -83,7 +82,7 @@ public void testShouldReturnEmptyAttributeValuesWhenPresentAndTheValueIsActually
8382
assertThat(body.getAttribute("style"), equalTo(""));
8483
}
8584

86-
@Ignore({CHROME, OPERA, IPHONE, ANDROID, SELENESE})
85+
@Ignore({OPERA, IPHONE, ANDROID, SELENESE})
8786
@Test
8887
public void testShouldReturnTheValueOfTheDisabledAttributeAsNullIfNotSet() {
8988
driver.get(pages.formPage);
@@ -338,7 +337,7 @@ public void testCanRetrieveTheCurrentValueOfATextFormField_textArea() {
338337
assertEquals("hello world", element.getAttribute("value"));
339338
}
340339

341-
@Ignore({CHROME, OPERA, IPHONE, ANDROID, SELENESE})
340+
@Ignore({OPERA, IPHONE, ANDROID, SELENESE})
342341
@Test
343342
public void testShouldReturnNullForNonPresentBooleanAttributes() {
344343
driver.get(pages.booleanAttributes);

‎java/client/test/org/openqa/selenium/ElementFindingTest.java‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import static org.junit.Assert.assertTrue;
2929
import static org.junit.Assert.fail;
3030
import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
31-
import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
3231
import static org.openqa.selenium.testing.Ignore.Driver.IE;
3332
import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
3433
import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
@@ -516,7 +515,6 @@ public void testShouldBeAbleToFindElementsByCssSelector() {
516515
}
517516

518517
@JavascriptEnabled
519-
@Ignore(CHROME)
520518
@Test
521519
public void testShouldBeAbleToFindAnElementByCompoundCssSelector() {
522520
driver.get(pages.xhtmlTestPage);
@@ -525,7 +523,6 @@ public void testShouldBeAbleToFindAnElementByCompoundCssSelector() {
525523
}
526524

527525
@JavascriptEnabled
528-
@Ignore(CHROME)
529526
@Test
530527
public void testShouldBeAbleToFindElementsByCompoundCssSelector() {
531528
driver.get(pages.xhtmlTestPage);
@@ -620,7 +617,7 @@ public void testAnElementFoundInADifferentFrameViaJsCanBeUsed() {
620617
}
621618

622619
@Test
623-
@Ignore({CHROME, OPERA})
620+
@Ignore({OPERA})
624621
public void findsByLinkTextOnXhtmlPage() {
625622
if (isOldIe(driver)) {
626623
// Old IE doesn't render XHTML pages, don't try loading XHTML pages in it

‎java/client/test/org/openqa/selenium/ElementSelectingTest.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import static org.junit.Assert.assertThat;
2626
import static org.junit.Assert.assertTrue;
2727
import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
28-
import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
2928
import static org.openqa.selenium.testing.Ignore.Driver.OPERA_MOBILE;
3029
import static org.openqa.selenium.testing.Ignore.Driver.SELENESE;
3130
import static org.openqa.selenium.TestWaiter.waitFor;
@@ -113,7 +112,7 @@ public void testClickingOnASelectedRadioButtonShouldLeaveItSelected() {
113112
assertTrue(button.isSelected());
114113
}
115114

116-
@Ignore(value = {CHROME, SELENESE, ANDROID}, reason = "Android: opens a dialog.")
115+
@Ignore(value = {SELENESE, ANDROID}, reason = "Android: opens a dialog.")
117116
@Test
118117
public void testShouldBeAbleToToggleEnabledMultiSelectOption() {
119118
driver.get(pages.formPage);

‎java/client/test/org/openqa/selenium/FrameSwitchingTest.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
import static org.openqa.selenium.WaitingConditions.pageTitleToBe;
3838
import static org.openqa.selenium.testing.Ignore.Driver.ALL;
3939
import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
40-
import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
4140
import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
4241
import static org.openqa.selenium.testing.Ignore.Driver.OPERA_MOBILE;
4342
import static org.openqa.selenium.testing.Ignore.Driver.PHANTOMJS;
@@ -421,7 +420,7 @@ public void testShouldNotBeAbleToDoAnythingTheFrameIsDeletedFromUnderUs() {
421420
}
422421
}
423422

424-
@Ignore(value = {CHROME, SELENESE}, reason = "These drivers still return frame title.")
423+
@Ignore(value = {SELENESE}, reason = "These drivers still return frame title.")
425424
@Test
426425
public void testShouldReturnWindowTitleInAFrameset() {
427426
driver.get(pages.framesetPage);

‎java/client/test/org/openqa/selenium/GetMultipleAttributeTest.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,13 @@
2424

2525
import static org.junit.Assert.assertEquals;
2626
import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
27-
import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
2827
import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
2928
import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
3029
import static org.openqa.selenium.testing.Ignore.Driver.SELENESE;
3130

3231
public class GetMultipleAttributeTest extends JUnit4TestBase {
3332

34-
@Ignore({CHROME, OPERA, IPHONE, ANDROID, SELENESE})
33+
@Ignore({OPERA, IPHONE, ANDROID, SELENESE})
3534
@Test
3635
public void testMultipleAttributeShouldBeNullWhenNotSet() {
3736
driver.get(pages.selectPage);

‎java/client/test/org/openqa/selenium/RenderedWebElementTest.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
public class RenderedWebElementTest extends JUnit4TestBase {
5252

5353
@JavascriptEnabled
54-
@Ignore({ANDROID, CHROME, HTMLUNIT, OPERA, SELENESE})
54+
@Ignore({ANDROID, HTMLUNIT, OPERA, SELENESE})
5555
@Test
5656
public void testShouldPickUpStyleOfAnElement() {
5757
driver.get(pages.javascriptPage);
@@ -68,7 +68,7 @@ public void testShouldPickUpStyleOfAnElement() {
6868
}
6969

7070
@JavascriptEnabled
71-
@Ignore({ANDROID, CHROME, HTMLUNIT, OPERA, SELENESE})
71+
@Ignore({ANDROID, HTMLUNIT, OPERA, SELENESE})
7272
@Test
7373
public void testGetCssValueShouldReturnStandardizedColour() {
7474
driver.get(pages.colorPage);
@@ -266,7 +266,7 @@ public Boolean call() throws Exception {
266266

267267
@JavascriptEnabled
268268
@Test
269-
@Ignore({CHROME, OPERA, OPERA_MOBILE})
269+
@Ignore({OPERA, OPERA_MOBILE})
270270
public void canClickOnASuckerFishStyleMenu() throws InterruptedException {
271271
assumeTrue(hasInputDevices());
272272
assumeTrue(TestUtilities.isNativeEventsEnabled(driver));
@@ -424,7 +424,7 @@ public void testMovingMouseToRelativeZeroElementOffset() {
424424

425425
@JavascriptEnabled
426426
@NeedsFreshDriver
427-
@Ignore(value = {CHROME, HTMLUNIT, SELENESE}, reason = "Advanced mouse actions only implemented in rendered browsers")
427+
@Ignore(value = {HTMLUNIT, SELENESE}, reason = "Advanced mouse actions only implemented in rendered browsers")
428428
@Test
429429
public void testMoveRelativeToBody() {
430430
if (!hasInputDevices() || !TestUtilities.isNativeEventsEnabled(driver)) {

‎java/client/test/org/openqa/selenium/SelectElementHandlingTest.java‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import static org.junit.Assert.assertThat;
2424
import static org.junit.Assert.assertTrue;
2525
import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
26-
import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
2726
import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
2827
import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
2928
import static org.openqa.selenium.testing.Ignore.Driver.SELENESE;
@@ -34,7 +33,7 @@
3433

3534
public class SelectElementHandlingTest extends JUnit4TestBase {
3635

37-
@Ignore({CHROME, SELENESE, IPHONE, OPERA, ANDROID})
36+
@Ignore({SELENESE, IPHONE, OPERA, ANDROID})
3837
@Test
3938
public void testShouldBePossibleToDeselectASingleOptionFromASelectWhichAllowsMultipleChoices() {
4039
driver.get(pages.formPage);
@@ -105,7 +104,7 @@ public void testShouldSelectFirstOptionByDefaultIfNoneIsSelected() {
105104
assertThat(two.isSelected(), is(true));
106105
}
107106

108-
@Ignore({SELENESE, CHROME})
107+
@Ignore({SELENESE})
109108
@Test
110109
public void testCanSelectElementsInOptGroups() {
111110
driver.get(pages.selectPage);

‎java/client/test/org/openqa/selenium/TextHandlingTest.java‎

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import static org.junit.Assert.assertThat;
2323
import static org.junit.Assert.assertTrue;
2424
import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
25-
import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
2625
import static org.openqa.selenium.testing.Ignore.Driver.HTMLUNIT;
2726
import static org.openqa.selenium.testing.Ignore.Driver.IE;
2827
import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
@@ -121,7 +120,7 @@ public void testShouldConvertANonBreakingSpaceIntoANormalSpaceCharacter() {
121120
assertThat(text, equalTo("This line has a non-breaking space"));
122121
}
123122

124-
@Ignore({CHROME, IPHONE, SELENESE})
123+
@Ignore({IPHONE, SELENESE})
125124
@Test
126125
public void testShouldNotCollapseANonBreakingSpaces() {
127126
driver.get(pages.simpleTestPage);
@@ -131,7 +130,7 @@ public void testShouldNotCollapseANonBreakingSpaces() {
131130
assertThat(text, equalTo("This line has a non-breaking space and spaces"));
132131
}
133132

134-
@Ignore({CHROME, IPHONE, SELENESE})
133+
@Ignore({IPHONE, SELENESE})
135134
@Test
136135
public void testShouldNotTrimNonBreakingSpacesAtTheEndOfALineInTheMiddleOfText() {
137136
driver.get(pages.simpleTestPage);
@@ -140,7 +139,7 @@ public void testShouldNotTrimNonBreakingSpacesAtTheEndOfALineInTheMiddleOfText()
140139
assertThat(text, startsWith("These lines \n"));
141140
}
142141

143-
@Ignore({CHROME, IPHONE, SELENESE})
142+
@Ignore({IPHONE, SELENESE})
144143
@Test
145144
public void testShouldNotTrimNonBreakingSpacesAtTheStartOfALineInTheMiddleOfText() {
146145
driver.get(pages.simpleTestPage);
@@ -149,7 +148,7 @@ public void testShouldNotTrimNonBreakingSpacesAtTheStartOfALineInTheMiddleOfText
149148
assertThat(text, containsString("\n have"));
150149
}
151150

152-
@Ignore({CHROME, IPHONE, SELENESE})
151+
@Ignore({IPHONE, SELENESE})
153152
@Test
154153
public void testShouldNotTrimTrailingNonBreakingSpacesInMultilineText() {
155154
driver.get(pages.simpleTestPage);
@@ -176,7 +175,7 @@ public void testShouldReturnTheEntireTextOfInlineElements() {
176175
assertThat(text, equalTo("An inline element"));
177176
}
178177

179-
@Ignore({SELENESE, IPHONE, ANDROID, CHROME, OPERA})
178+
@Ignore({SELENESE, IPHONE, ANDROID, OPERA})
180179
@Test
181180
public void testShouldRetainTheFormatingOfTextWithinAPreElement() {
182181
driver.get(pages.simpleTestPage);
@@ -188,7 +187,7 @@ public void testShouldRetainTheFormatingOfTextWithinAPreElement() {
188187
" "));
189188
}
190189

191-
@Ignore({SELENESE, IPHONE, ANDROID, CHROME, OPERA})
190+
@Ignore({SELENESE, IPHONE, ANDROID, OPERA})
192191
@Test
193192
public void testShouldRetainTheFormatingOfTextWithinAPreElementThatIsWithinARegularBlock() {
194193
driver.get(pages.simpleTestPage);
@@ -201,9 +200,8 @@ public void testShouldRetainTheFormatingOfTextWithinAPreElementThatIsWithinARegu
201200
"after pre"));
202201
}
203202

204-
@Ignore(value = {SELENESE, IPHONE, CHROME, IE, OPERA, OPERA_MOBILE}, reason =
203+
@Ignore(value = {SELENESE, IPHONE, IE, OPERA, OPERA_MOBILE}, reason =
205204
"iPhone: sendKeys is broken;"
206-
+ " Chrome: not handling a space character properly."
207205
+ " Opera,IE: inserts \r\n instead of \n.")
208206
@Test
209207
public void testShouldBeAbleToSetMoreThanOneLineOfTextInATextArea() {

0 commit comments

Comments
 (0)