Report all hostname state failures

Follows whatwg/url@c23aec1. Does not impact normal URL parsing, but instead only direct usage of the underlying URL record API.

Author: domenic

lib/url-state-machine.js

@@ -536,9 +536,9 @@ function URLStateMachine(input, base, encodingOverride, url, stateOverride) {
  this.state = stateOverride || "scheme start";
 
  this.buffer = "";
- this.atFlag = false;
- this.arrFlag = false;
- this.passwordTokenSeenFlag = false;
+ this.atSignSeen = false;
+ this.insideBrackets = false;
+ this.passwordTokenSeen = false;
 
  this.input = Array.from(this.input, c => c.codePointAt(0));
 
@@ -751,22 +751,22 @@ URLStateMachine.prototype["parse special authority ignore slashes"] = function p
 URLStateMachine.prototype["parse authority"] = function parseAuthority(c, cStr) {
  if (c === p("@")) {
  this.parseError = true;
- if (this.atFlag) {
+ if (this.atSignSeen) {
  this.buffer = `%40${this.buffer}`;
  }
- this.atFlag = true;
+ this.atSignSeen = true;
 
  // careful, this is based on buffer and has its own pointer (this.pointer != pointer) and inner chars
  const len = countSymbols(this.buffer);
  for (let pointer = 0; pointer < len; ++pointer) {
  const codePoint = this.buffer.codePointAt(pointer);
 
- if (codePoint === p(":") && !this.passwordTokenSeenFlag) {
- this.passwordTokenSeenFlag = true;
+ if (codePoint === p(":") && !this.passwordTokenSeen) {
+ this.passwordTokenSeen = true;
  continue;
  }
  const encodedCodePoints = utf8PercentEncodeCodePoint(codePoint, isUserinfoPercentEncode);
- if (this.passwordTokenSeenFlag) {
+ if (this.passwordTokenSeen) {
  this.url.password += encodedCodePoints;
  } else {
  this.url.username += encodedCodePoints;
@@ -775,7 +775,7 @@ URLStateMachine.prototype["parse authority"] = function parseAuthority(c, cStr)
  this.buffer = "";
  } else if (isNaN(c) || c === p("/") || c === p("?") || c === p("#") ||
  (isSpecial(this.url) && c === p("\\"))) {
- if (this.atFlag && this.buffer === "") {
+ if (this.atSignSeen && this.buffer === "") {
  this.parseError = true;
  return failure;
  }
@@ -794,14 +794,14 @@ URLStateMachine.prototype["parse host"] = function parseHostName(c, cStr) {
  if (this.stateOverride && this.url.scheme === "file") {
  --this.pointer;
  this.state = "file host";
- } else if (c === p(":") && !this.arrFlag) {
+ } else if (c === p(":") && !this.insideBrackets) {
  if (this.buffer === "") {
  this.parseError = true;
  return failure;
  }
 
  if (this.stateOverride === "hostname") {
- return false;
+ return failure;
  }
 
  const host = parseHost(this.buffer, isNotSpecial(this.url));
@@ -821,7 +821,7 @@ URLStateMachine.prototype["parse host"] = function parseHostName(c, cStr) {
  } else if (this.stateOverride && this.buffer === "" &&
  (includesCredentials(this.url) || this.url.port !== null)) {
  this.parseError = true;
- return false;
+ return failure;
  }
 
  const host = parseHost(this.buffer, isNotSpecial(this.url));
@@ -837,9 +837,9 @@ URLStateMachine.prototype["parse host"] = function parseHostName(c, cStr) {
  }
  } else {
  if (c === p("[")) {
- this.arrFlag = true;
+ this.insideBrackets = true;
  } else if (c === p("]")) {
- this.arrFlag = false;
+ this.insideBrackets = false;
  }
  this.buffer += cStr;
  }