Skip to content

Commit 73cb827

Browse files
committed
fixed bad merge and linting errors
1 parent a2cc940 commit 73cb827

File tree

4 files changed

+18
-16
lines changed

4 files changed

+18
-16
lines changed

.jscsrc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
"requireCapitalizedComments": null,
66
"requireEarlyReturn": null,
77
"disallowSemicolons": true,
8+
"disallowMultipleSpaces": true,
9+
"disallowPaddingNewlinesInBlocks": true,
810
"requireCurlyBraces": null,
911
"requireSpaceBeforeKeywords": [
1012
"else",

lib/ControlledRefreshableListView.js

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,16 @@ var ControlledRefreshableListView = React.createClass({
2929
propTypes: {
3030
onRefresh: PropTypes.func.isRequired,
3131
isRefreshing: PropTypes.bool.isRequired,
32-
refreshPrompt: PropTypes.oneOfType([PropTypes.string, PropTypes.element]),
32+
waitingForRelease: PropTypes.bool,
33+
onHold: PropTypes.func,
34+
onPull: PropTypes.func,
35+
pullingPrompt: PropTypes.oneOfType([PropTypes.string, PropTypes.element]),
36+
pullingIndicator: PropTypes.oneOfType([PropTypes.func, PropTypes.element]),
37+
holdingPrompt: PropTypes.oneOfType([PropTypes.string, PropTypes.element]),
38+
holdingIndicator: PropTypes.oneOfType([PropTypes.string, PropTypes.element]),
3339
refreshDescription: PropTypes.oneOfType([PropTypes.string, PropTypes.element]),
34-
pullingIndicatorComponent: PropTypes.oneOfType([PropTypes.func, PropTypes.element]),
35-
holdingIndicatorComponent: PropTypes.oneOfType([PropTypes.func, PropTypes.element]),
40+
refreshingPrompt: PropTypes.oneOfType([PropTypes.string, PropTypes.element]),
41+
refreshingIndicator: PropTypes.oneOfType([PropTypes.func, PropTypes.element]),
3642
refreshingIndicatorComponent: PropTypes.oneOfType([PropTypes.func, PropTypes.element]),
3743
minPulldownDistance: PropTypes.number,
3844
ignoreInertialScroll: PropTypes.bool,
@@ -66,7 +72,6 @@ var ControlledRefreshableListView = React.createClass({
6672
},
6773
componentWillReceiveProps(nextProps) {
6874
if (!this.props.isRefreshing && nextProps.isRefreshing && this.isTouching) {
69-
7075
this.waitingForRelease = true
7176
this.setState({waitingForRelease: true})
7277
}
@@ -169,26 +174,21 @@ var ControlledRefreshableListView = React.createClass({
169174
pullingPrompt,
170175
holdingPrompt,
171176
refreshingPrompt,
177+
refreshDescription,
172178
pullingIndicator,
173179
holdingIndicator,
174180
refreshingIndicator,
175181
} = this.props
176182
var refreshingIndicatorProps = {
177183
isRefreshing,
178-
<<<<<<< HEAD
179-
description: refreshDescription,
180-
prompt: refreshPrompt,
181-
pulldownDistance: -(this.lastScrollY || 0),
182-
=======
183184
pullingIndicator,
184185
holdingIndicator,
185186
refreshingIndicator,
186187
pullingPrompt: pullingPrompt || 'Pull to refresh',
187188
holdingPrompt: holdingPrompt || 'Release to refresh',
188-
refreshingPrompt: refreshingPrompt,
189+
refreshingPrompt: refreshingPrompt || refreshDescription,
189190
isTouching: this.isTouching,
190191
isWaitingForRelease: this.isWaitingForRelease(),
191-
>>>>>>> atom2ueki-master
192192
}
193193
return createElementFrom(this.props.refreshingIndicatorComponent, refreshingIndicatorProps)
194194
},
@@ -221,10 +221,10 @@ var stylesheet = StyleSheet.create({
221221
fillParent: {
222222
backgroundColor: 'transparent',
223223
position: 'absolute',
224-
top: 0,
225-
left: 0,
226-
right: 0,
227-
bottom: 0,
224+
top: 0,
225+
left: 0,
226+
right: 0,
227+
bottom: 0,
228228
},
229229
// offsetParent: {
230230
// position: 'relative',

lib/RefreshingIndicator.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ var RefreshingIndicator = React.createClass({
2020
holdingPrompt: PropTypes.oneOfType([PropTypes.string, PropTypes.element]),
2121
refreshingPrompt: PropTypes.oneOfType([PropTypes.string, PropTypes.element]),
2222
isTouching: PropTypes.bool.isRequired,
23+
isRefreshing: PropTypes.bool.isRequired,
2324
isWaitingForRelease: PropTypes.bool.isRequired,
2425
},
2526
getDefaultProps() {

lib/__tests__/RefreshingIndicator-test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ describe('RefreshingIndicator', function() {
1313
})
1414

1515
it('renders an activity indicator', function() {
16-
1716
let renderer = this.shallowRender(
1817
<RefreshingIndicator
1918
description={description}

0 commit comments

Comments
 (0)