Skip to content

Selectmenu #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 409 commits into from
Closed

Selectmenu #866

Changes from 1 commit
Commits
Show all changes
409 commits
Select commit Hold shift + click to select a range
f2228b0
Selectmenu: remove unwanted Menu mouseover event, fixes problem with …
fnagel Feb 26, 2012
156d0fb
Selectmenu: fix for IEs item hover problem, overflow CSS properties n…
fnagel Feb 26, 2012
e299e9a
Selectmenu: added empty.html visual test, small improvements in html …
fnagel Feb 26, 2012
cea6844
Selectmenu: removed working but illogical closest context
fnagel Feb 26, 2012
b1a72e6
Selectmenu: small improvements, code clean-up, lint, coding guidelines
fnagel Feb 26, 2012
72c17f0
Selectmenu: added a temp fix for Safari to make unit test work, see h…
fnagel Feb 28, 2012
8c10c1e
Revert "Selectmenu: added a temp fix for Safari to make unit test wor…
scottgonzalez Mar 1, 2012
b4d9eee
Merge branch 'master' into selectmenu
scottgonzalez Mar 1, 2012
94f8514
Tests: equals() -> equal().
scottgonzalez Mar 1, 2012
682a321
Merge branch 'master' into selectmenu
scottgonzalez Mar 14, 2012
e38feea
Merge branch 'master' into selectmenu
kborchers Mar 19, 2012
4a9e26c
Selectmenu: Add links to all menu items to be in line with what menu …
kborchers Mar 19, 2012
1092551
Selectmenu: fixed small regression which added unwanted, empty optgro…
fnagel Apr 1, 2012
ec5f2ae
Selectmenu: removed unnecessary unit test (has link test for disabled…
fnagel Apr 1, 2012
41dfb09
Merge branch 'master' into selectmenu
fnagel May 14, 2012
c6a8d7e
Merge branch 'master' into selectmenu
fnagel May 14, 2012
31a38e9
Selectmenu: Upgrade jQuery to 1.7.2.
fnagel May 14, 2012
8fbdd7c
Menu: Check that the event object is defined before checking type, in…
fnagel May 16, 2012
eae21ff
Selectmenu: make optgroups work again, needed because of Menu widget …
fnagel May 16, 2012
b348d32
Selectmenu: trim trailing spaces
fnagel May 16, 2012
ddf7c27
Selectmenu: prevent copyright notice from being removed by minification
fnagel May 16, 2012
360e885
Selectmenu: updated copyright year
fnagel May 16, 2012
4460376
Selectmenu: Upgrade tests to jQuery 1.7.2
fnagel May 16, 2012
ff957dd
Selectmenu: Update unit tests
fnagel May 16, 2012
c5a449d
Selectmenu: small fixes for lint tests
fnagel May 16, 2012
c3f6bd9
Selectmenu: trim trailing spaces
fnagel May 16, 2012
ec6d88f
Selectmenu: small fixes for lint tests
fnagel May 24, 2012
b30184d
Merge with master
fnagel May 24, 2012
7345e43
Selectmenu: make use of Menu option 'role'
fnagel May 24, 2012
37a8047
Selectmenu: small fixes for lint tests
fnagel May 24, 2012
d4ec5cb
Selectmenu: make use of Menu option 'role' (follow-up), no need to ad…
fnagel May 24, 2012
8abe1d0
Merge remote-tracking branch 'origin/master' into selectmenu
fnagel May 24, 2012
749c8fb
Merge branch 'master' into selectmenu
fnagel May 31, 2012
39532f0
Selectmenu: Use new uniqueId method for generating id's
fnagel May 31, 2012
5092d02
Merge branch 'master' into selectmenu
fnagel Jul 12, 2012
8f5f4b3
Selectmenu: changed _bind to _on
fnagel Jul 12, 2012
b19986a
Selectmenu: changed _unbind to _off
fnagel Jul 12, 2012
001bd3d
Selectmenu: trim trailing spaces
fnagel Jul 12, 2012
c7e9906
Selectmenu: added complex menu demo to compatibility visual test
fnagel Jul 12, 2012
44f9b8f
Selectmenu: updated copyright notice
fnagel Jul 16, 2012
83f4249
Selectmenu: split core unit test for state synchronization in keydown…
fnagel Jul 16, 2012
06372cd
Selectmenu: follow-up to 'split core unit test for state synchronizat…
fnagel Jul 16, 2012
549b97e
Selectmenu: Fixed event unbinding.
scottgonzalez Jul 17, 2012
dd272e7
Merge branch 'master' into selectmenu
fnagel Aug 11, 2012
b6e2467
Selectmenu: remove unbind Menu document event to reset mouseHandled f…
fnagel Aug 11, 2012
c179902
Simplify licensing.
fnagel Aug 11, 2012
daadc84
Merge branch 'master' into selectmenu
fnagel Aug 30, 2012
66156aa
Selectmenu: Upgrade jQuery to 1.8.0.
fnagel Aug 30, 2012
fb87e1c
Selectmenu tests: Added test for widget() method.
fnagel Aug 30, 2012
5e12c54
Selectmenu tests: Upgrade visual tests to jQuery to 1.8.0.
fnagel Sep 4, 2012
cca4e77
Merge branch 'master' into selectmenu
fnagel Oct 3, 2012
fc729a8
Selectmenu: Upgrade jQuery to 1.8.2.
fnagel Oct 3, 2012
c59fbba
Merge branch 'master' into selectmenu
fnagel Oct 12, 2012
20d19db
Selectmenu: ARIA tweaks for keyboard events and closed menu operation
robertbeuligmann Oct 15, 2012
8e1e956
Selectmenu: corrections based on code review.
robertbeuligmann Oct 16, 2012
99aa0ff
Selectmenu: Fix data naming, should be [namespace]-[widgetname]-[value]
jzaefferer Oct 19, 2012
86f4c2f
Selectmenu: follow-up to "Fix data naming"
fnagel Oct 25, 2012
e059376
Selectmenu tests: add test for button aria-labelledby attribute
fnagel Oct 25, 2012
b8cce0c
Selectmenu: small improvement for label id setting
fnagel Oct 25, 2012
9cf0f21
Selectmenu: add removeUniqueId to destroy method
fnagel Oct 25, 2012
b2d50f9
Selectmenu: fixed aria-activedescendant for button element
fnagel Oct 25, 2012
e7e73ce
Selectmenu tests: aria-activedescendant für button
fnagel Oct 25, 2012
7c1a9d9
Selectmenu: hopefully fixed multiple a11y bugs (value is recognized b…
fnagel Oct 25, 2012
a59b3c7
Selectmenu: reset aria-activedescendant to selected item when menu is…
fnagel Oct 25, 2012
228a9b9
Selectmenu: follow-up for menu, reset aria-activedescendant to select…
fnagel Oct 25, 2012
b6e1c86
Selectmenu: Do not remove ui-state-focus class on first button focus
fnagel Oct 26, 2012
684b55b
Selectmenu: Do not remove ui-state-focus class on first button focus …
fnagel Oct 27, 2012
7725e4a
Selectmenu: focus selected item when menu opens
fnagel Nov 10, 2012
a9a6e3b
Selectmenu: proposed fix for menu delay issue
fnagel Nov 10, 2012
94b3a65
Selectmenu tests: adjust accessibility test
fnagel Nov 10, 2012
7ce8e05
Merge branch 'master' into selectmenu
fnagel Nov 10, 2012
12fe28f
Selectmenu: cleanup, CGL and lint fix
fnagel Nov 12, 2012
0734314
Selectmenu: updated copyright notice
fnagel Nov 12, 2012
967e2b7
Selectmenu: fix doctype declaration
fnagel Nov 12, 2012
daec559
Merge branch 'master' into selectmenu
fnagel Nov 12, 2012
2bb459f
Selectmenu tests: lint fixes
fnagel Nov 13, 2012
4160978
Selectmenu: CSS fix for gravatar demo
fnagel Nov 13, 2012
b7ee7b2
Selectmenu: lint fixes
fnagel Nov 13, 2012
d24e62b
Selectmenu tests: lint fixes
fnagel Nov 13, 2012
8cbbf33
Selectmenu: Add selectmenu to build/test
jzaefferer Nov 15, 2012
f86168b
Merge branch 'master' into selectmenu
jzaefferer Nov 15, 2012
dff9917
Selectmenu: Customize job title for testswarm, until merge to master
jzaefferer Nov 15, 2012
a2d3ef3
Selectmenu: Fix testswarm job title
jzaefferer Nov 15, 2012
dec8399
Selectmenu: Upgrade jQuery to 1.8.3
fnagel Nov 23, 2012
0d4a8dc
Selectmenu tests: Upgrade jQuery to 1.8.3
fnagel Nov 23, 2012
e25cdd8
Merge branch 'master' into selectmenu
fnagel Nov 23, 2012
709f75b
Selectmenu: Reformatted CSS to use better coding standard
fnagel Nov 23, 2012
4e68c52
Selectmenu: removed Position Plugin offset option to fix broken pop-u…
fnagel Nov 23, 2012
36533a7
Merge branch 'master' into selectmenu
fnagel Nov 28, 2012
7328333
Selectmenu: better position handling, fixes issue with wrong styles w…
fnagel Nov 28, 2012
8a62210
Selectmenu: updated documentation link
fnagel Nov 29, 2012
b014bc6
Selectmenu: alphabetical ordering of options and callback events
fnagel Nov 29, 2012
080b5bc
Selectmenu: remove unnecessary comments from _create
fnagel Nov 29, 2012
71e744a
Selectmenu: move button event binding in _drawButton
fnagel Nov 29, 2012
e581a13
Selectmenu: remove unnecessary comments from _drawButton
fnagel Nov 29, 2012
a177a92
Selectmenu: improve element creation
fnagel Nov 29, 2012
1e6808a
Selectmenu: replace placeholder entity with  
fnagel Nov 29, 2012
ac7b8f9
Selectmenu: improve comment in _drawMenu
fnagel Nov 29, 2012
f622428
Selectmenu: improve disabled check in open method
fnagel Nov 29, 2012
18ecaf4
Selectmenu: added comment about popup positioning
fnagel Nov 29, 2012
d1c9837
Selectmenu tests: remove themeswitcher as its no longer available
fnagel Nov 29, 2012
6fd9d8f
Selectmenu tests: add button widget js file to fix compatibility test
fnagel Nov 29, 2012
0d28263
Selectmenu: make isOpen check a guard clause in close method
fnagel Nov 29, 2012
04553a7
Selectmenu: close guard close should test for closed menu
fnagel Dec 3, 2012
cba09da
Selectmenu: guard clause should not return false
fnagel Dec 3, 2012
60e3302
Selectmenu: use text() instead of html() as the option and optgroup i…
fnagel Dec 3, 2012
40b8567
Selectmenu: fix jQuery UI framework icon demo
fnagel Dec 3, 2012
aa60a9e
Selectmenu: use item.index instead of _getSelectedItem method
fnagel Dec 3, 2012
e6aca63
Selectmenu: simplify $.each usage in _readOptions method
fnagel Dec 3, 2012
7a05c65
Selectmenu: Cleanup demo markup
jzaefferer Dec 7, 2012
15032d1
Selectmenu: Remove colons from labels, annoying for screenreader-user…
jzaefferer Dec 9, 2012
2845d38
Selectmenu: Select value when closing with space
jzaefferer Dec 9, 2012
d1350f9
Selectmenu: improve option appendTo handling in appendTo method
fnagel Dec 12, 2012
f6372bd
Merge branch 'master' into selectmenu
fnagel Dec 12, 2012
0732835
Selectmenu: use method _documentClick for adding events to the document
fnagel Dec 12, 2012
20aad07
Selectmenu: fix comment typo
fnagel Dec 12, 2012
812a90f
Selectmenu tests: improve focus event test so its possible to test fo…
fnagel Dec 12, 2012
b15ae2a
Selectmenu: merge and explain if statements in Menu focus event, remo…
fnagel Dec 12, 2012
ed422bd
Selectmenu: removed ugly workaround for IE9 to make sure the menu is …
fnagel Dec 12, 2012
8901960
Selectmenu: revert change to text instead of html, otherwise the unic…
fnagel Dec 12, 2012
c69d01b
Selectmenu: replace placeholder entity with  
fnagel Dec 12, 2012
1ea2256
Selectmenu: fix closing of empty selects
fnagel Dec 13, 2012
21e46b8
Selectmenu tests: improve and merge visual tests
fnagel Dec 13, 2012
e2b5123
Selectmenu: introduce _setText helper function to improve handling of…
fnagel Dec 14, 2012
25023c3
Selectmenu tests: fixed headlines in disable / empty visual test
fnagel Dec 15, 2012
8aa24dd
Merge branch 'master' into selectmenu
fnagel Dec 15, 2012
57ecee8
Selectmenu: rework appendTo functionality
fnagel Dec 15, 2012
930e9d5
Selectmenu tests: adjust common test to new appendTo mechanism
fnagel Dec 15, 2012
ae68ab8
Selectmenu tests: improve appendTo option tests
fnagel Dec 15, 2012
58f2706
Selectmenu tests: improve compatibility visual test in order to work …
fnagel Dec 15, 2012
1b1dbd8
Selectmenu tests: add Position plugin to loaded resources
fnagel Dec 15, 2012
76f335e
Selectmenu: CGL and lint fixes
fnagel Dec 15, 2012
1afede8
Selectmenu: remove zIndex
fnagel Dec 16, 2012
52fc8e3
Selectmenu: add option icons
fnagel Dec 18, 2012
2ab514f
Selectmenu: improved custom render demo CGL
fnagel Dec 18, 2012
a787d52
Selectmenu: make dropdown style default and remove option dropdown
fnagel Dec 19, 2012
8462194
Selectmenu tests: remove option dropdown
fnagel Dec 19, 2012
50d7a96
Selectmenu: improve _setOption to make it possible to change icons op…
fnagel Dec 19, 2012
dab7bf8
Merge branch 'master' into selectmenu
fnagel Dec 19, 2012
44e472a
Merge branch 'master' into selectmenu
fnagel Dec 20, 2012
2eb9223
Selectmenu: make sure position option could be overwritten
fnagel Jan 2, 2013
1ba02e9
Merge branch 'master' into selectmenu
fnagel Jan 2, 2013
c960285
Selectmenu: improve element creation
fnagel Jan 2, 2013
f244108
Selectmenu tests: Convert single quotes to double quotes
fnagel Jan 2, 2013
fb47fd0
Merge branch 'master' into selectmenu
jzaefferer Jan 3, 2013
dcb28a7
Merge branch 'master' into selectmenu
fnagel Jan 10, 2013
4d77ca3
Selectmenu: Update copyright year to 2013
fnagel Jan 10, 2013
f5e65b0
Merge branch 'master' into selectmenu
fnagel Jan 18, 2013
de149c4
Selectmenu: Updating to jQuery 1.9.0
fnagel Jan 18, 2013
91dde04
Merge branch 'master' into selectmenu
fnagel Jan 30, 2013
3a17a91
Selectmenu: click on the text of the button did not open the menu in …
fnagel Feb 8, 2013
9719719
Selectmenu: rename _setSelected to _setAria
fnagel Feb 9, 2013
110cab1
Selectmenu tests: remove toggle event as its removed
fnagel Feb 9, 2013
b81bb0b
Selectmenu tests: add unit test to make sure button text is changed w…
fnagel Feb 9, 2013
a7b4f29
Merge branch 'master' into selectmenu
fnagel Feb 9, 2013
78f9362
Selectmenu: Updating jQuery to 1.9.1.
fnagel Feb 9, 2013
fdf3af6
Selectmenu tests: check for too much fired focus events
fnagel Feb 13, 2013
75cfcf2
Selectmenu tests: wrong selected item when using keyboard control on …
fnagel Feb 13, 2013
640d308
Selectmenu: menu focus reset when menu is closed, prevents issues whe…
fnagel Feb 13, 2013
8a5e869
Selectmenu: aria-activedescendant should be set when item is selected…
fnagel Feb 13, 2013
06eb3bf
Selectmenu: menuItems now contains link elements instead of list elem…
fnagel Feb 13, 2013
50bb89f
Selectmenu: follow-up to: menuItems now contains link elements instea…
fnagel Feb 13, 2013
f434271
Selectmenu tests: remove console statements
fnagel Feb 13, 2013
d599bf9
Selectmenu tests: CGL, trim triling spaces
fnagel Feb 13, 2013
d94e217
Selectmenu: Fix whitespace (trailing ws on 1 line) and lint issues (u…
jzaefferer Mar 1, 2013
dffe8f6
Merge branch 'master' into selectmenu
fnagel Mar 3, 2013
8787cb0
Selectmenu: switch from a to button element
fnagel Mar 7, 2013
890881d
Selectmenu tests: switch from a to button element
fnagel Mar 7, 2013
f08b0af
Selectmenu: make sure menu is refreshed at least once before opening
fnagel Mar 7, 2013
f128292
Selectmenu: fix keyboard control issue
fnagel Mar 7, 2013
6e80a19
Selectmenu: improve keyboard control
fnagel Mar 7, 2013
022079a
Selectmenu: Switch to span to avoid cranky click/keydown event handling
jzaefferer Mar 7, 2013
8fc08a1
Selectmenu tests: adjust test to change from button to span element
fnagel Mar 7, 2013
66ba390
Selectmenu: remove button wrapper element
fnagel Mar 7, 2013
6acc6bd
Selectmenu tests: adjust tests due to removed button wrapper element
fnagel Mar 7, 2013
0bf91a4
Merge branch 'master' into selectmenu
fnagel Mar 7, 2013
a7ea386
Selectmenu tests: improve widget method tests
fnagel Mar 7, 2013
775b81b
Selectmenu: Remove aria-selected, since that only causes NVDA to anno…
jzaefferer Mar 9, 2013
2f7bd63
Selectmenu tests: remove aria-selected tests
fnagel Mar 9, 2013
a6e2863
Selectmenu: simplify overflow selectmenu init in default demo
fnagel Mar 9, 2013
e2235bd
Selectmenu: simplify custom render demo inits
fnagel Mar 9, 2013
5a9a80f
Selectmenu: improve custom render demo
fnagel Mar 9, 2013
1ce8d87
Merge branch 'master' into selectmenu
fnagel Mar 19, 2013
ba0e804
Selectmenu: add ui-state-disabled and aria-disabled manually as its r…
fnagel Mar 19, 2013
26c528a
Selectmenu: Updating to use instance method on bridge, see 4fce29e935…
fnagel Mar 19, 2013
73c7342
Merge branch 'master' into selectmenu
fnagel Apr 2, 2013
4efd006
Merge branch 'master' into selectmenu
fnagel Apr 21, 2013
e1590c4
Selectmenu: clean up custom render demo
fnagel Apr 29, 2013
c0fa69d
Selectmenu: clean up default demo
fnagel Apr 29, 2013
026f517
Selectmenu Tests: updated jQuery and old testsuite version
fnagel Apr 29, 2013
4d986a4
Selectmenu Tests: rename wrapper divs
fnagel Apr 29, 2013
c73f7e8
Selectmenu Tests: cleanup unit tests
fnagel Apr 29, 2013
8b6c81e
Selectmenu Tests: remove unneeded test
fnagel Apr 29, 2013
1fa8c20
Selectmenu Tests: use simulate instead of trigger
fnagel Apr 29, 2013
f2bd236
Selectmenu Tests: remove unneeded test
fnagel Apr 29, 2013
1cca829
Selectmenu Tests: add toLowerCase() to node type checks
fnagel Apr 29, 2013
0d7b25d
Selectmenu Tests: clean up spacing and intention
fnagel Apr 29, 2013
d66528b
Selectmenu Test: rename widget method test
fnagel Apr 29, 2013
c1667ba
Selectmenu Tests: change doctype to lower case
fnagel Apr 29, 2013
ad30163
Selectmenu Tests: added labels to disabled empty visual test
fnagel Apr 29, 2013
0264f07
Selectmenu: clean up CSS
fnagel Apr 29, 2013
60eed79
Selectmenu: improve id generation
fnagel Apr 29, 2013
a29cfb8
Selectmenu: don't quote click, remove extraneous space
fnagel Apr 29, 2013
68c7485
Selectmenu: Comments start with an uppercase letter
fnagel Apr 29, 2013
b84cd7e
Selectmenu: simplify tabindex attribute setting on button create
fnagel Apr 29, 2013
8b4a304
Selectmenu: set aria states as string if needed
fnagel Apr 29, 2013
00ab497
Selectmenu: improve readability when creating button elements
fnagel Apr 29, 2013
5e9ad9b
Selectmenu: blank before comment
fnagel Apr 29, 2013
0631d76
Selectmenu: rename var to focusIndex
fnagel Apr 29, 2013
ee9c443
Selectmenu: adjust comments, trim trailing spaces
fnagel Apr 29, 2013
17b6ff7
Selectmenu: use guard clause for option length checking in refresh
fnagel Apr 29, 2013
d4f13bc
Selectmenu: add spaces
fnagel Apr 29, 2013
666927b
Selectmenu: add renderItemData method similar to autocomplete
fnagel Apr 29, 2013
b8339eb
Selectmenu: use outerWidth for menu width calculation
fnagel Apr 29, 2013
4c930fd
Selectmenu Tests: add spaces to [0]
fnagel Apr 29, 2013
70a4360
Selectmenu: do not call _getCreateOptions directly
fnagel Apr 29, 2013
61be0e5
Selectmenu: using prop instead of attr to receive disabled state
fnagel Apr 29, 2013
f96ee5e
Tests: added Selectenu to Dialog Widgets compound test
fnagel Apr 29, 2013
6640925
Merge branch 'master' into selectmenu
fnagel Apr 29, 2013
7715c71
Dialog Tests: move dialog initialization to top in order to make stac…
fnagel Apr 30, 2013
255d4f6
Selectmenu; improve HTML building in custom render demo
fnagel Apr 30, 2013
5e06985
Selectmenu Tests: add visual test selectmenu in tabs, removed old com…
fnagel Apr 30, 2013
adcfa63
Selectmenu Tests: use asyncTest when working with focus events
fnagel Apr 30, 2013
ef8c792
Selectmenu Tests: fixed spacing
fnagel May 7, 2013
1c878ce
Selectmenu Tests: simplify asyncTest
fnagel May 7, 2013
97cca1e
Selectmenu Tests: improve events tests, check for original option ele…
fnagel May 12, 2013
ddf1347
Selectmenu: use dynamic binding for document event
fnagel May 15, 2013
cb5f9bb
Merge branch 'master' into selectmenu
fnagel May 15, 2013
83e795f
Selectmenu: recheck CSS overflow IE hack and add comment
fnagel May 16, 2013
7e0737e
Selectmenu: recheck refresh fallback for IE and add a comment
fnagel May 16, 2013
cccb8c6
Merge branch 'master' into selectmenu
fnagel May 24, 2013
29f726c
Selectmenu tests: improve focus callback event test, add keydown focu…
fnagel May 30, 2013
a572f72
Selectmenu: do not call focus menu method when close method us used
fnagel May 30, 2013
dfbd712
Selectmenu: fire focus event when menu is opened
fnagel May 30, 2013
84ee9d8
Selectmenu tests: improve all other focus callback event tests
fnagel May 30, 2013
e7d200f
Selectmenu tests: test if close event is fired when selectmenu is clo…
fnagel May 30, 2013
7be7d96
Selectmenu: use that.focusIndex != null instead of !== undefined when…
fnagel May 30, 2013
bfd3c4a
Selectmenu: remove unused var
fnagel May 30, 2013
57fa482
Merge branch 'master' into selectmenu
fnagel May 30, 2013
33317c9
Selectmenu tests: combine visual tests to one
fnagel May 30, 2013
1821517
Selectmenu Tests: use asyncTest when working with focus events
fnagel May 30, 2013
ab48ae7
Selectmenu tests: fix lint issues
fnagel Jun 4, 2013
ffc7d31
Merge branch 'master' into selectmenu
jzaefferer Jun 5, 2013
ab72fd1
Selectmenu: Fix htmllint warnings
jzaefferer Jun 5, 2013
9992d46
Merge branch 'master' into selectmenu
fnagel Jun 24, 2013
b735152
Selectmenu: CSS Framework: Update API links from the old docs site to…
fnagel Jun 24, 2013
2c9f5a8
Selectmenu Tests: use trigger instead of simulate for click events in…
fnagel Jul 1, 2013
ff1bb14
Selectmenu: prevent widget from item looping
fnagel Jul 1, 2013
3483b94
Selectmenu Tests: add item looping tests
fnagel Jul 1, 2013
b9fa8f7
Selectmenu Tests: fix lint issues
fnagel Jul 1, 2013
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Selectmenu: remove unnecessary comments from _create
  • Loading branch information
@fnagel
fnagel committed Nov 29, 2012
commit 080b5bca0a80eb5f736d1af4195297efec08aa82
3 changes: 0 additions & 3 deletions ui/jquery.ui.selectmenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@ $.widget( "ui.selectmenu", {
},

_create: function() {
// make / set unique id
var selectmenuId = this.element.uniqueId().attr( "id" );

// array of button and menu id's
this.ids = { id: selectmenuId, button: selectmenuId + "-button", menu: selectmenuId + "-menu" };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

{ id: ..., button: .... }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.ids.id is odd, use a better name than id, such as element or select.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

this._drawButton();
Expand Down