Skip to content

Commit a528aad

Browse files
snicolldsyer
authored andcommitted
@ConfigurationProperties bean must be public (spring-guides#35)
The code sample for `@ConfigurationProperties` beans are package protected (it's missing the `public` keyword). Metadata will be generated only if the bean is public. This commit fixes both the code and the samples.
1 parent 6828b74 commit a528aad

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

auth-server/README.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,13 @@ before, but a single method for each provider:
7272
----
7373
@Bean
7474
@ConfigurationProperties("github")
75-
ClientResources github() {
75+
public ClientResources github() {
7676
return new ClientResources();
7777
}
7878
7979
@Bean
8080
@ConfigurationProperties("facebook")
81-
ClientResources facebook() {
81+
public ClientResources facebook() {
8282
return new ClientResources();
8383
}
8484
----

auth-server/src/main/java/com/example/SocialApplication.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,13 +106,13 @@ public FilterRegistrationBean oauth2ClientFilterRegistration(OAuth2ClientContext
106106

107107
@Bean
108108
@ConfigurationProperties("github")
109-
ClientResources github() {
109+
public ClientResources github() {
110110
return new ClientResources();
111111
}
112112

113113
@Bean
114114
@ConfigurationProperties("facebook")
115-
ClientResources facebook() {
115+
public ClientResources facebook() {
116116
return new ClientResources();
117117
}
118118

github/README.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,13 @@ supplemented with similar methods `github()` and `githubResource()`:
7272
----
7373
@Bean
7474
@ConfigurationProperties("github.client")
75-
OAuth2ProtectedResourceDetails github() {
75+
public OAuth2ProtectedResourceDetails github() {
7676
return new AuthorizationCodeResourceDetails();
7777
}
7878
7979
@Bean
8080
@ConfigurationProperties("github.resource")
81-
ResourceServerProperties githubResource() {
81+
public ResourceServerProperties githubResource() {
8282
return new ResourceServerProperties();
8383
}
8484
----

github/src/main/java/com/example/SocialApplication.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,13 +106,13 @@ public FilterRegistrationBean oauth2ClientFilterRegistration(OAuth2ClientContext
106106

107107
@Bean
108108
@ConfigurationProperties("github")
109-
ClientResources github() {
109+
public ClientResources github() {
110110
return new ClientResources();
111111
}
112112

113113
@Bean
114114
@ConfigurationProperties("facebook")
115-
ClientResources facebook() {
115+
public ClientResources facebook() {
116116
return new ClientResources();
117117
}
118118

manual/README.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ the filter also needs to know about the client registration with Facebook:
8383
8484
@Bean
8585
@ConfigurationProperties("facebook.client")
86-
OAuth2ProtectedResourceDetails facebook() {
86+
public OAuth2ProtectedResourceDetails facebook() {
8787
return new AuthorizationCodeResourceDetails();
8888
}
8989
----
@@ -96,7 +96,7 @@ info endpoint is in Facebook:
9696
----
9797
@Bean
9898
@ConfigurationProperties("facebook.resource")
99-
ResourceServerProperties facebookResource() {
99+
public ResourceServerProperties facebookResource() {
100100
return new ResourceServerProperties();
101101
}
102102
----

manual/src/main/java/com/example/SocialApplication.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,13 @@ private Filter ssoFilter() {
9191

9292
@Bean
9393
@ConfigurationProperties("facebook.client")
94-
OAuth2ProtectedResourceDetails facebook() {
94+
public OAuth2ProtectedResourceDetails facebook() {
9595
return new AuthorizationCodeResourceDetails();
9696
}
9797

9898
@Bean
9999
@ConfigurationProperties("facebook.resource")
100-
ResourceServerProperties facebookResource() {
100+
public ResourceServerProperties facebookResource() {
101101
return new ResourceServerProperties();
102102
}
103103

0 commit comments

Comments
 (0)