Refactored initializer

Author: staugaard

lib/zendesk_api/actions.rb

@@ -107,11 +107,7 @@ def find!(client, options = {})
  yield req if block_given?
  end
 
- new(client).tap do |resource|
- resource.handle_response(response)
- resource.set_includes(resource, includes, response.body)
- resource.attributes.clear_changes
- end
+ new_from_response(client, response, includes)
  end
 
  # Finds, returning nil if it fails
@@ -157,10 +153,7 @@ def create_many!(client, attributes_array)
  yield req if block_given?
  end
 
- JobStatus.new(client).tap do |resource|
- resource.handle_response(response)
- resource.attributes.clear_changes
- end
+ JobStatus.new_from_response(client, response)
  end
  end
 
@@ -218,10 +211,7 @@ def destroy_many!(client, ids)
  yield req if block_given?
  end
 
- JobStatus.new(client).tap do |resource|
- resource.handle_response(response)
- resource.attributes.clear_changes
- end
+ JobStatus.new_from_response(client, response)
  end
  end
 

lib/zendesk_api/resource.rb

@@ -66,6 +66,14 @@ def initialize(client, attributes = {})
  @attributes.clear_changes unless new_record?
  end
 
+ def self.new_from_response(client, response, includes = nil)
+ new(client).tap do |resource|
+ resource.handle_response(response)
+ resource.set_includes(resource, includes, response.body) if includes
+ resource.attributes.clear_changes
+ end
+ end
+
  # Passes the method onto the attributes hash.
  # If the attributes are nested (e.g. { :tickets => { :id => 1 } }), passes the method onto the nested hash.
  def method_missing(*args, &block)