Skip to content

Commit 99f2d7f

Browse files
committed
removed circular deps so tests run on node
1 parent b92d16c commit 99f2d7f

File tree

4 files changed

+17
-18
lines changed

4 files changed

+17
-18
lines changed

modules/angular2/src/core/compiler/element_binder.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import {int, isBlank, BaseException} from 'angular2/src/facade/lang';
2-
import {ProtoElementInjector} from './element_injector';
2+
import * as eiModule from './element_injector';
33
import {DirectiveMetadata} from './directive_metadata';
44
import {List, StringMap} from 'angular2/src/facade/collection';
55
import {ProtoView} from './view';
66

77
export class ElementBinder {
8-
protoElementInjector:ProtoElementInjector;
8+
protoElementInjector:eiModule.ProtoElementInjector;
99
componentDirective:DirectiveMetadata;
1010
viewportDirective:DirectiveMetadata;
1111
textNodeIndices:List<int>;
@@ -18,7 +18,7 @@ export class ElementBinder {
1818
distanceToParent:int;
1919
constructor(
2020
index:int, parent:ElementBinder, distanceToParent: int,
21-
protoElementInjector: ProtoElementInjector, componentDirective:DirectiveMetadata,
21+
protoElementInjector: eiModule.ProtoElementInjector, componentDirective:DirectiveMetadata,
2222
viewportDirective:DirectiveMetadata) {
2323
if (isBlank(index)) {
2424
throw new BaseException('null index not allowed.');

modules/angular2/src/core/compiler/element_injector.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {ViewContainer} from 'angular2/src/core/compiler/view_container';
99
import {NgElement} from 'angular2/src/core/dom/element';
1010
import {Directive, onChange, onDestroy} from 'angular2/src/core/annotations/annotations';
1111
import {BindingPropagationConfig} from 'angular2/src/core/compiler/binding_propagation_config';
12-
import {PrivateComponentLocation} from 'angular2/src/core/compiler/private_component_location';
12+
import * as pclModule from 'angular2/src/core/compiler/private_component_location';
1313
import {reflector} from 'angular2/src/reflection/reflection';
1414

1515
var _MAX_DIRECTIVE_CONSTRUCTION_COUNTER = 10;
@@ -33,7 +33,7 @@ class StaticKeys {
3333
this.ngElementId = Key.get(NgElement).id;
3434
this.viewContainerId = Key.get(ViewContainer).id;
3535
this.bindingPropagationConfigId = Key.get(BindingPropagationConfig).id;
36-
this.privateComponentLocationId = Key.get(PrivateComponentLocation).id;
36+
this.privateComponentLocationId = Key.get(pclModule.PrivateComponentLocation).id;
3737
}
3838

3939
static instance() {
@@ -603,7 +603,7 @@ export class ElementInjector extends TreeNode {
603603
if (keyId === staticKeys.bindingPropagationConfigId) return this._preBuiltObjects.bindingPropagationConfig;
604604

605605
if (keyId === staticKeys.privateComponentLocationId) {
606-
return new PrivateComponentLocation(this, this._preBuiltObjects.element, this._preBuiltObjects.view);
606+
return new pclModule.PrivateComponentLocation(this, this._preBuiltObjects.element, this._preBuiltObjects.view);
607607
}
608608

609609
//TODO add other objects as needed

modules/angular2/src/core/compiler/private_component_location.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
11
import {Directive} from 'angular2/src/core/annotations/annotations'
22
import {NgElement} from 'angular2/src/core/dom/element';
3-
import {ElementInjector} from './element_injector';
4-
import {ProtoView, View} from './view';
3+
import * as viewModule from './view';
4+
import * as eiModule from './element_injector';
55
import {ShadowDomStrategy} from './shadow_dom_strategy';
66
import {EventManager} from 'angular2/src/core/events/event_manager';
77
import {ListWrapper} from 'angular2/src/facade/collection';
88
import {Type} from 'angular2/src/facade/lang';
99

1010

1111
export class PrivateComponentLocation {
12-
_elementInjector:ElementInjector;
12+
_elementInjector:eiModule.ElementInjector;
1313
_elt:NgElement;
14-
_view:View;
14+
_view:viewModule.View;
1515

16-
constructor(elementInjector:ElementInjector, elt:NgElement, view:View){
16+
constructor(elementInjector:eiModule.ElementInjector, elt:NgElement, view:viewModule.View){
1717
this._elementInjector = elementInjector;
1818
this._elt = elt;
1919
this._view = view;
2020
}
2121

22-
createComponent(type:Type, annotation:Directive, componentProtoView:ProtoView,
22+
createComponent(type:Type, annotation:Directive, componentProtoView:viewModule.ProtoView,
2323
eventManager:EventManager, shadowDomStrategy:ShadowDomStrategy) {
2424
var context = this._elementInjector.createPrivateComponent(type, annotation);
2525

modules/angular2/test/core/compiler/integration_spec.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import {Lexer, Parser, dynamicChangeDetection,
2121

2222
import {Compiler, CompilerCache} from 'angular2/src/core/compiler/compiler';
2323
import {DirectiveMetadataReader} from 'angular2/src/core/compiler/directive_metadata_reader';
24-
import {ShadowDomStrategy, NativeShadowDomStrategy} from 'angular2/src/core/compiler/shadow_dom_strategy';
24+
import {ShadowDomStrategy, EmulatedUnscopedShadowDomStrategy} from 'angular2/src/core/compiler/shadow_dom_strategy';
2525
import {PrivateComponentLocation} from 'angular2/src/core/compiler/private_component_location';
2626
import {PrivateComponentLoader} from 'angular2/src/core/compiler/private_component_loader';
2727
import {TemplateLoader} from 'angular2/src/core/compiler/template_loader';
@@ -67,7 +67,7 @@ export function main() {
6767
directiveMetadataReader = new DirectiveMetadataReader();
6868

6969
var urlResolver = new UrlResolver();
70-
shadowDomStrategy = new NativeShadowDomStrategy(new StyleUrlResolver(urlResolver));
70+
shadowDomStrategy = new EmulatedUnscopedShadowDomStrategy(new StyleUrlResolver(urlResolver), null);
7171

7272
compiler = createCompiler(tplResolver, dynamicChangeDetection);
7373
});
@@ -247,7 +247,7 @@ export function main() {
247247

248248
cd.detectChanges();
249249

250-
expect(view.nodes[0].shadowRoot.childNodes[0].nodeValue).toEqual('hello');
250+
expect(view.nodes).toHaveText('hello');
251251
async.done();
252252
});
253253
}));
@@ -301,12 +301,12 @@ export function main() {
301301
ctx.ctxProp = 'some_id';
302302
cd.detectChanges();
303303
expect(view.nodes[0].id).toEqual('some_id');
304-
expect(DOM.getInnerHTML(view.nodes[0].shadowRoot.childNodes[0])).toEqual('Matched on id with some_id');
304+
expect(view.nodes).toHaveText('Matched on id with some_id');
305305

306306
ctx.ctxProp = 'other_id';
307307
cd.detectChanges();
308308
expect(view.nodes[0].id).toEqual('other_id');
309-
expect(DOM.getInnerHTML(view.nodes[0].shadowRoot.childNodes[0])).toEqual('Matched on id with other_id');
309+
expect(view.nodes).toHaveText('Matched on id with other_id');
310310

311311
async.done();
312312
});
@@ -534,7 +534,6 @@ export function main() {
534534
inline: '<dynamic-comp #dynamic></dynamic-comp>',
535535
directives: [DynamicComp]
536536
}));
537-
538537
compiler.compile(MyComp).then((pv) => {
539538
createView(pv);
540539

0 commit comments

Comments
 (0)