Accomodating mvs pr comments

Author: uditbhatia

sagemaker-python-sdk/tensorflow_script_mode_horovod/tensorflow_script_mode_horovod.ipynb

@@ -108,14 +108,18 @@
  "metadata": {},
  "source": [
  "### 1. Accept `--model_dir` command-line argument\n",
- "Modify script to accept `--model_dir` as command-line argument which will define the directory path where the output model should be saved. This will be equal to `/opt/ml/model/`\n",
+ "Modify script to accept `--model_dir` as command-line argument which will define the directory path (i.e. `/opt/ml/model/`) where the output model should be saved. As Sagemaker destroys the complete cluster at the end of training, saving the model to `/opt/ml/model/` directory preserves the trained model from getting lost as SageMaker at the end of trainig pushes all the data in `/opt/ml/model/` to s3. \n",
+ "\n",
+ "This also allows the SageMaker training to integrate with other SageMaker services such as Inference and also allows you to host the trained model outside SageMaker.\n",
  "\n",
  "Here is the code that needs to be added to script:\n",
  "\n",
  "```\n",
  "parser = argparse.ArgumentParser()\n",
  "parser.add_argument('--model_dir', type=str)\n",
- "```"
+ "```\n",
+ "\n",
+ "More details can be found [here](https://github.com/aws/sagemaker-containers/blob/master/README.md)."
  ]
  },
  {
@@ -135,7 +139,9 @@
  "\n",
  "x_test = np.load(os.path.join(os.environ['SM_CHANNEL_TEST'], 'test.npz'))['data']\n",
  "y_test = np.load(os.path.join(os.environ['SM_CHANNEL_TEST'], 'test.npz'))['labels']\n",
- "```\n"
+ "```\n",
+ "\n",
+ "List of all environemnt variables set by SageMaker which are accessible inside training script can be found [here](https://github.com/aws/sagemaker-containers/blob/master/README.md)."
  ]
  },
  {
@@ -445,7 +451,7 @@
  "source": [
  "import boto3\n",
  "from botocore.exceptions import ClientError\n",
- "\n",
+ "from time import sleep\n",
  "\n",
  "def create_vpn_infra(stack_name=\"hvdvpcstack\"):\n",
  " cfn = boto3.client(\"cloudformation\")\n",
@@ -466,6 +472,7 @@
  "\n",
  " while describe_stack[\"StackStatus\"] == \"CREATE_IN_PROGRESS\":\n",
  " describe_stack = cfn.describe_stacks(StackName=stack_name)[\"Stacks\"][0]\n",
+ " sleep(0.5)\n",
  "\n",
  " if describe_stack[\"StackStatus\"] != \"CREATE_COMPLETE\":\n",
  " raise ValueError(\"Stack creation failed in state: {}\".format(describe_stack[\"StackStatus\"]))\n",