Skip to content

Fix flake rev issue #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2024
Merged

Fix flake rev issue #2310

merged 3 commits into from
Sep 29, 2024

Conversation

@Lagoja
Copy link
Contributor

@Lagoja Lagoja commented Sep 28, 2024

Summary

Nix flake fails to build with:

 error: attribute 'dirtyShortRev' missing at /nix/store/m5mqwkz0ss2cav2c9663mx8vwsmvcas3-source/flake.nix:21:28: 20| then "${x}-${self.shortRev}" 21| else "${x}-${self.dirtyShortRev}") | ^ 22| ];

This fixes the issue

How was it tested?

nix build github:jetify-com/devbox/jl/fix-flake-rev
@Lagoja Lagoja requested a review from gcurtis September 28, 2024 01:29
gcurtis
gcurtis approved these changes Sep 28, 2024
View reviewed changes
@Lagoja Lagoja merged commit fcf3a42 into main Sep 29, 2024
28 checks passed
@Lagoja Lagoja deleted the jl/fix-flake-rev branch September 29, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Lagoja @gcurtis