internal/devbox: handle whitespace in paths

[gcurtis]

Make sure the flake ref is URL-encoded and quote the rcfile in the shellrc template.

Fixes #2290.

[savil]

Awesome!

I think this solves #1914, and #971 as well? Could you close them if so?

[Lagoja]

@savil last time you looked into this issue -- did we discover a compatibility risk with older versions of Nix?

[savil]

@Lagoja I think this was my revert commit #1935. Unfortunately, I forgot to document the reason I had to revert :(

But digging some more, I believe the prior approach relied on using percent-encoded paths which were only supported on nix 2.19. However, I think @gcurtis 's flake.Ref handles this internally (how?), as per his claim here (see internal discussion)

@gcurtis how does flake.Ref handle spaces internally so they work with older nix versions?

[gcurtis]

@savil I wasn't aware of that revert. Let me try testing this with older Nix versions before merging.

[gcurtis]

@savil flake.Ref.String uses url.PathEscape to encode the file path. I think in the reverted PR we were calling flake.ParseRef("path:" + flakeDirResolved), so it assumed that flakeDirResolved was already encoded (the path: makes it a URL).

I added a test and ran it back to Nix 2.17 and everything seemed to work. I also hardened the shell quoting using the same logic we use for environment variables.

[sentry]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ **exec.ExitError: <redacted *errors.withStack>: <redacted errors.withMessage>: <redacted exec.ExitError> go.jetpack.io/devbox/internal/nix in (*Nix).Pri... View Issue

_{Did you find this useful? React with a 👍 or 👎}