patchpkg: restore removed refs to build deps #2249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mikeland73 approved these changes Sep 4, 2024
Add a `devbox patch --restore-refs` flag that attempts to restore removed store path references. It works by finding store paths that have had their hashes replaced with e's (`/nix/store/eeee...-foo`) and then searching the package's build environment for store paths with matching names. For example, for the removed reference `/nix/store/eee...-foo-1.2.3` search all environment variables for a path ending in `foo-1.2.3`, then overwrite the removed reference with the one we found.
gcurtis force-pushed the gcurtis/patchpkg-refs branch from f95694f to 3543d8d Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add a
devbox patch --restore-refsflag that attempts to restore removed store path references. It works by finding store paths that have had their hashes replaced with e's (/nix/store/eeee...-foo) and then searching the package's build environment for store paths with matching names.For example, for the removed reference
/nix/store/eee...-foo-1.2.3search all environment variables for a path ending infoo-1.2.3, then overwrite the removed reference with the one we found.