feat: handle line endings in snapshot #15708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
babel-jest
babel-plugin-jest-hoist
babel-preset-jest
create-jest
@jest/diff-sequences
expect
@jest/expect-utils
jest
jest-changed-files
jest-circus
jest-cli
jest-config
@jest/console
@jest/core
@jest/create-cache-key-function
jest-diff
jest-docblock
jest-each
@jest/environment
jest-environment-jsdom
@jest/environment-jsdom-abstract
jest-environment-node
@jest/expect
@jest/fake-timers
@jest/get-type
@jest/globals
jest-haste-map
jest-jasmine2
jest-leak-detector
jest-matcher-utils
jest-message-util
jest-mock
@jest/pattern
jest-phabricator
jest-regex-util
@jest/reporters
jest-resolve
jest-resolve-dependencies
jest-runner
jest-runtime
@jest/schemas
jest-snapshot
@jest/snapshot-utils
@jest/source-map
@jest/test-result
@jest/test-sequencer
@jest/transform
@jest/types
jest-util
jest-validate
jest-watcher
jest-worker
pretty-format
commit: |
cpojer reviewed Jul 2, 2025
Comment on lines 78 to 98
| const LINE_ENDING_MAPPINGS = [ | ||
| ['\r\n', '\\r\\n'], | ||
| ['\r', '\\r'], | ||
| ['\n', '\\n'], | ||
| ] as const; | ||
| | ||
| const normalizeTestNameForKey = (testName: string): string => { | ||
| let result = testName; | ||
| for (const [original, escaped] of LINE_ENDING_MAPPINGS) { | ||
| result = result.replaceAll(original, escaped); | ||
| } | ||
| return result; | ||
| }; | ||
| | ||
| const denormalizeTestNameFromKey = (key: string): string => { | ||
| let result = key; | ||
| for (const [original, escaped] of LINE_ENDING_MAPPINGS) { | ||
| result = result.replaceAll(escaped, original); | ||
| } | ||
| return result; | ||
| }; |
Member
There was a problem hiding this comment.
Could these not just be a single regex?
cpojer approved these changes Jul 2, 2025
Member
cpojer left a comment
cpojer left a comment There was a problem hiding this comment.
I like it, but we can probably just use one regex each, no?
Contributor Author
| I changed it to replaceAll func |
| This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
resolves #15672
I am not sure whether this is a correct approach for this issue. However, when line ending is explicitly defined in a string content, I think normalizing makes more sense.
Test plan
e2e