Skip to content

Commit 14a8e89

Browse files
committed
Use native Object.assign
Closes Flipboard#144
1 parent 5aaf226 commit 14a8e89

File tree

7 files changed

+7
-15
lines changed

7 files changed

+7
-15
lines changed

lib/Canvas.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
'use strict';
22

3-
var assign = require('react/lib/Object.assign');
4-
53
// Note that this class intentionally does not use PooledClass.
64
// DrawingUtils manages <canvas> pooling for more fine-grained control.
75

@@ -20,7 +18,7 @@ function Canvas (width, height, scale) {
2018
this._canvas.getContext('2d').scale(this.scale, this.scale);
2119
}
2220

23-
assign(Canvas.prototype, {
21+
Object.assign(Canvas.prototype, {
2422

2523
getRawCanvas: function () {
2624
return this._canvas;

lib/ContainerMixin.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@
55

66
var React = require('react');
77
var ReactMultiChild = require('react/lib/ReactMultiChild');
8-
var assign = require('object-assign');
98
var emptyObject = require('fbjs/lib/emptyObject');
109

11-
var ContainerMixin = assign({}, ReactMultiChild.Mixin, {
10+
var ContainerMixin = Object.assign({}, ReactMultiChild.Mixin, {
1211

1312
/**
1413
* Moves a child component to the supplied index.

lib/Image.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22

33
var React = require('react');
4-
var assign = require('react/lib/Object.assign');
54
var createComponent = require('./createComponent');
65
var LayerMixin = require('./LayerMixin');
76
var Layer = require('./Layer');
@@ -86,9 +85,9 @@ var Image = React.createClass({
8685

8786
render: function () {
8887
var rawImage;
89-
var imageStyle = assign({}, this.props.style);
90-
var style = assign({}, this.props.style);
91-
var backgroundStyle = assign({}, this.props.style);
88+
var imageStyle = Object.assign({}, this.props.style);
89+
var style = Object.assign({}, this.props.style);
90+
var backgroundStyle = Object.assign({}, this.props.style);
9291
var useBackingStore = this.state.loaded ? this.props.useBackingStore : false;
9392

9493
// Hide the image until loaded.

lib/ImageCache.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22

33
var EventEmitter = require('events');
4-
var assign = require('react/lib/Object.assign');
54

65
var NOOP = function () {};
76

@@ -22,7 +21,7 @@ function Img (src) {
2221
this.setMaxListeners(100);
2322
}
2423

25-
assign(Img.prototype, EventEmitter.prototype, {
24+
Object.assign(Img.prototype, EventEmitter.prototype, {
2625

2726
/**
2827
* Pooling owner looks for this

lib/ListView.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22

33
var React = require('react');
4-
var assign = require('react/lib/Object.assign');
54
var Scroller = require('scroller');
65
var Group = require('./Group');
76
var clamp = require('./clamp');

lib/createComponent.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// Adapted from ReactART:
44
// https://github.com/reactjs/react-art
55

6-
var assign = require('react/lib/Object.assign');
76
var RenderLayer = require('./RenderLayer');
87

98
function createComponent (name) {
@@ -18,7 +17,7 @@ function createComponent (name) {
1817
};
1918
ReactCanvasComponent.displayName = name;
2019
for (var i = 1, l = arguments.length; i < l; i++) {
21-
assign(ReactCanvasComponent.prototype, arguments[i]);
20+
Object.assign(ReactCanvasComponent.prototype, arguments[i]);
2221
}
2322

2423
return ReactCanvasComponent;

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
"dependencies": {
4242
"fbjs": "^0.4.0",
4343
"linebreak": "^0.3.0",
44-
"object-assign": "^4.0.1",
4544
"scroller": "git://github.com/mjohnston/scroller"
4645
}
4746
}

0 commit comments

Comments
 (0)