Generate and revoke access tokens with standard UI components #1597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
small UI update for the access tokens replace yui-button with jenkins-button to be synv with the overall jenkins styling Use a dialog to confirm revocation of access tokens
MarkEWaite changed the title MarkEWaite changed the title 
MarkEWaite approved these changes Jul 26, 2024
MarkEWaite added a commit to MarkEWaite/docker-lfs that referenced this pull request Jul 29, 2024
Incremental that includes: * Use poll env when checking for ls-remote branches jenkinsci/git-plugin#1511 * Optionally report the most recent commit as the changelog of a new build jenkinsci/git-plugin#1565 https://issues.jenkins.io/browse/JENKINS-4162 https://issues.jenkins.io/browse/JENKINS-14138 https://issues.jenkins.io/browse/JENKINS-26354 https://issues.jenkins.io/browse/JENKINS-68030 * Generate and revoke access tokens with standard UI components jenkinsci/git-plugin#1597 * Do not assume HttpResponse is a functional interface jenkinsci/git-plugin#1590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
small UI update for the access tokens
replace yui-button with jenkins-button to be in sync with the overall jenkins styling
Use a dialog to confirm revocation of access tokens
Before:
After:
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code. If a checkbox or line does not apply to this pull request, delete it. We prefer all checkboxes to be checked before a pull request is mergedTypes of changes
What types of changes does your code introduce? Put an
xin the boxes that apply. Delete the items in the list that do not applyFurther comments
If this is a relatively large or complex change, start the discussion by explaining why you chose the solution you did and what alternatives you considered.