Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Commit 3ef6f29

Browse files
committed
Move non-formatting method back to model.
1 parent e8e5d0e commit 3ef6f29

File tree

2 files changed

+10
-20
lines changed

2 files changed

+10
-20
lines changed

plugin/src/main/java/io/jenkins/plugins/coverage/metrics/model/ElementFormatter.java

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import java.util.List;
44
import java.util.Locale;
55
import java.util.NoSuchElementException;
6-
import java.util.Optional;
76
import java.util.regex.Pattern;
87
import java.util.stream.Collectors;
98
import java.util.stream.Stream;
@@ -15,7 +14,6 @@
1514
import edu.hm.hafner.coverage.FractionValue;
1615
import edu.hm.hafner.coverage.IntegerValue;
1716
import edu.hm.hafner.coverage.Metric;
18-
import edu.hm.hafner.coverage.Node;
1917
import edu.hm.hafner.coverage.Percentage;
2018
import edu.hm.hafner.coverage.Value;
2119

@@ -417,23 +415,6 @@ public List<String> getFormattedValues(final Stream<? extends Value> values, fin
417415
return values.map(value -> formatDetails(value, locale)).collect(Collectors.toList());
418416
}
419417

420-
/**
421-
* Returns a stream of {@link Coverage} values for the given root node sorted by the metric ordinal.
422-
*
423-
* @param coverage
424-
* The coverage root node
425-
*
426-
* @return a stream containing the existent coverage values
427-
*/
428-
public Stream<Coverage> getSortedCoverageValues(final Node coverage) {
429-
return Metric.getCoverageMetrics()
430-
.stream()
431-
.map(m -> m.getValueFor(coverage))
432-
.flatMap(Optional::stream)
433-
.filter(value -> value instanceof Coverage)
434-
.map(Coverage.class::cast);
435-
}
436-
437418
/**
438419
* Returns a localized human-readable label for the specified metric.
439420
*

plugin/src/main/java/io/jenkins/plugins/coverage/metrics/steps/CoverageViewModel.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -487,10 +487,19 @@ public List<String> getMetrics() {
487487
}
488488

489489
private Stream<Coverage> sortCoverages() {
490-
return ELEMENT_FORMATTER.getSortedCoverageValues(coverage)
490+
return getSortedCoverageValues()
491491
.filter(c -> c.getTotal() > 1); // ignore elements that have a total of 1
492492
}
493493

494+
private Stream<Coverage> getSortedCoverageValues() {
495+
return Metric.getCoverageMetrics()
496+
.stream()
497+
.map(m -> m.getValueFor(coverage))
498+
.flatMap(Optional::stream)
499+
.filter(value -> value instanceof Coverage)
500+
.map(Coverage.class::cast);
501+
}
502+
494503
public List<Integer> getCovered() {
495504
return getCoverageCounter(Coverage::getCovered);
496505
}

0 commit comments

Comments
 (0)