issue 51

Author: VeldinaElena

requirements-dev.txt

@@ -6,7 +6,6 @@ chardet==4.0.0
 click==7.1.2
 colorama==0.4.4
 comtypes==1.1.8
-ddt==1.4.1
 flake8==3.8.4
 idna==2.10
 isort==5.7.0

requirements.txt

@@ -1,4 +1,3 @@
-ddt==1.4.1
 pywin32==300
 selenium==3.141.0
 urllib3==1.26.4

tests/jdi_uitests_webtests/test/common/check_box_test.py

@@ -1,96 +1,69 @@
-import unittest
-
 import pytest
-from ddt import data, ddt, unpack
 
-from JDI.core.settings.jdi_settings import JDISettings
 from JDI.jdi_assert.testing.assertion import Assert
 from tests.jdi_uitests_webtests.main.enums.preconditions import Preconditions
 from tests.jdi_uitests_webtests.main.page_objects.epam_jdi_site import EpamJDISite
 from tests.jdi_uitests_webtests.main.utils.common_action_data import CommonActionsData
-from tests.jdi_uitests_webtests.test.init_tests import InitTests
 
 MSG_TRUE = "Water: condition changed to true"
 MSG_FALSE = "Water: condition changed to false"
 
 
-@pytest.mark.web
-@ddt
-class CheckBoxText(InitTests):
+@pytest.fixture
+def checkbox_setup(site):
+ Preconditions.METALS_AND_COLORS_PAGE.is_in_state()
 
- check_box = EpamJDISite.metals_colors_page.cb_water
 
- def setUp(self):
- super(CheckBoxText, self).setUp(self.id().split(".")[-1])
- Preconditions.METALS_AND_COLORS_PAGE.is_in_state()
+@pytest.mark.web
+class TestCheckBoxText:
 
- def tearDown(self):
- JDISettings.get_driver_factory().get_driver().refresh()
+ check_box = EpamJDISite.metals_colors_page.cb_water
 
- @data(("True", True), ("1", True), ("False", False), ("0", False))
- @unpack
- def test_set_value(self, input, expected):
+ @pytest.mark.parametrize("input, expected", [("True", True), ("1", True), ("False", False), ("0", False)])
+ def test_set_value(self, checkbox_setup, input, expected):
  if not expected:
  EpamJDISite.metals_colors_page.cb_water.click()
  EpamJDISite.metals_colors_page.cb_water.set_value(input)
  CommonActionsData.check_action("Water: condition changed to " + str(expected).lower())
 
- @data(
- "true ",
- "1 ",
- " false",
- "0 ",
- " ",
- "123",
- " 1",
- " 0",
- "!@#$%^&*",
- "qwdewf",
- "1qwe",
- "1qwe",
- "true123",
- "123true",
- "false123",
- "123false",
- "o",
- "O",
- "tr ue",
- )
- def test_set_value_nothing_changes(self, input):
+ @pytest.mark.parametrize("input", ["true ", "1 ", " false", "0 ", " ", "123", " 1", " 0", "!@#$%^&*",
+ "qwdewf", "1qwe", "1qwe", "true123", "123true", "false123", "123false",
+ "o", "O", "tr ue", ])
+ def test_set_value_nothing_changes(self, checkbox_setup, input):
  self.check_box.click()
  self.check_box.set_value(input)
  CommonActionsData.check_action(MSG_TRUE)
  self.check_box.click()
  self.check_box.set_value(input)
  CommonActionsData.check_action(MSG_FALSE)
 
- def test_check_single(self):
+ def test_check_single(self, checkbox_setup):
  self.check_box.check()
  CommonActionsData.check_action(MSG_TRUE)
 
- def test_uncheck_single(self):
+ def test_uncheck_single(self, checkbox_setup):
  self.check_box.click()
  self.check_box.uncheck()
  CommonActionsData.check_action(MSG_FALSE)
 
- def test_is_check(self):
+ def test_is_check(self, checkbox_setup):
  Assert.assert_false(self.check_box.is_checked())
  self.check_box.click()
  Assert.assert_true(self.check_box.is_checked())
 
- def test_multi_uncheck(self):
+ def test_multi_uncheck(self, checkbox_setup):
  self.check_box.click()
  self.check_box.uncheck()
  self.check_box.uncheck()
  CommonActionsData.check_action(MSG_FALSE)
 
- def test_multi_check(self):
+ def test_multi_check(self, checkbox_setup):
  self.check_box.check()
  self.check_box.check()
  CommonActionsData.check_action(MSG_TRUE)
 
- def test_click(self):
+ def test_click(self, checkbox_setup):
  self.check_box.click()
  CommonActionsData.check_action(MSG_TRUE)
  self.check_box.click()
- CommonActionsData.check_action(MSG_FALSE)
+ CommonActionsData.check_action(MSG_FALSE)

tests/jdi_uitests_webtests/test/complex/check_list_test.py

@@ -1,7 +1,5 @@
-import unittest
-
 import pytest
-from ddt import data, ddt
+
 from selenium.webdriver.common.by import By
 
 from JDI.core.settings.jdi_settings import JDISettings
@@ -10,118 +8,117 @@
 from tests.jdi_uitests_webtests.main.enums.preconditions import Preconditions
 from tests.jdi_uitests_webtests.main.page_objects.epam_jdi_site import EpamJDISite
 from tests.jdi_uitests_webtests.main.utils.common_action_data import CommonActionsData
-from tests.jdi_uitests_webtests.test.init_tests import InitTests
 
 FIRE_MSG = "Fire: condition changed to true"
 WATER_MSG = "Water: condition changed to true"
 
 
+@pytest.fixture
+def check_list_setup(site):
+ Preconditions.METALS_AND_COLORS_PAGE.is_in_state()
+
+
 @pytest.mark.web
-@ddt
-class CheckListTests(InitTests):
+class TestCheckList:
  nature_options = ["Water", "Earth", "Wind", "Fire"]
  all_values = "Water, Earth, Wind, Fire"
 
  check_list = EpamJDISite.metals_colors_page.nature_check_list
 
- def setUp(self):
- super(CheckListTests, self).setUp(self.id().split(".")[-1])
- Preconditions.METALS_AND_COLORS_PAGE.is_in_state()
-
- @data("Fire", 4, Nature.FIRE)
- def test_select(self, value):
+ @pytest.mark.parametrize("value", ("Fire", 4, Nature.FIRE))
+ def test_select(self, check_list_setup, value):
  self.check_list.select(value)
  CommonActionsData.check_action(FIRE_MSG)
 
- def test_select_2_string(self):
+ def test_select_2_string(self, check_list_setup):
  self.check_list.select("Water", "Fire")
  CommonActionsData.check_action(FIRE_MSG, line_number=0)
  CommonActionsData.check_action(WATER_MSG, line_number=1)
 
- def test_select_2_index(self):
+ def test_select_2_index(self, check_list_setup):
  self.check_list.select(1, 4)
  CommonActionsData.check_action(FIRE_MSG, line_number=0)
  CommonActionsData.check_action(WATER_MSG, line_number=1)
 
- def test_select_2_enum(self):
+ def test_select_2_enum(self, check_list_setup):
  self.check_list.select(Nature.WATER, Nature.FIRE)
  CommonActionsData.check_action(FIRE_MSG, line_number=0)
  CommonActionsData.check_action(WATER_MSG, line_number=1)
 
- @data("Fire", 4, Nature.FIRE)
- def test_check(self, value):
+ @pytest.mark.parametrize("value", ("Fire", 4, Nature.FIRE))
+ def test_check(self, check_list_setup, value):
  self.check_list.check(value)
  CommonActionsData.check_action(FIRE_MSG)
 
- def test_check_2_string(self):
+ def test_check_2_string(self, check_list_setup):
  self.check_list.check("Water", "Fire")
  CommonActionsData.check_action(FIRE_MSG, line_number=0)
  CommonActionsData.check_action(WATER_MSG, line_number=1)
 
- def test_check_2_index(self):
+ def test_check_2_index(self, check_list_setup):
  self.check_list.check(1, 4)
  CommonActionsData.check_action(FIRE_MSG, line_number=0)
  CommonActionsData.check_action(WATER_MSG, line_number=1)
 
- def test_check_2_enum(self):
+ def test_check_2_enum(self, check_list_setup):
  self.check_list.check(Nature.WATER, Nature.FIRE)
  CommonActionsData.check_action(FIRE_MSG, line_number=0)
  CommonActionsData.check_action(WATER_MSG, line_number=1)
 
- def test_select_all(self):
+ def test_select_all(self, check_list_setup):
  self.check_list.select_all()
  CommonActionsData.check_action(FIRE_MSG, line_number=0)
  CommonActionsData.check_action("Wind: condition changed to true", line_number=1)
  CommonActionsData.check_action("Earth: condition changed to true", line_number=2)
  CommonActionsData.check_action(WATER_MSG, line_number=3)
  self.check_all_checked()
 
- def test_check_all(self):
+ def test_check_all(self, check_list_setup):
  self.check_list.check_all()
  CommonActionsData.check_action(FIRE_MSG, line_number=0)
  CommonActionsData.check_action("Wind: condition changed to true", line_number=1)
  CommonActionsData.check_action("Earth: condition changed to true", line_number=2)
  CommonActionsData.check_action(WATER_MSG, line_number=3)
  self.check_all_checked()
 
- def test_clear_all(self):
+ def test_clear_all(self, check_list_setup):
  self.check_list.check_all()
  self.check_all_checked()
  self.check_list.clear()
  self.check_all_unchecked()
 
- def test_uncheck_all(self):
+ def test_uncheck_all(self, check_list_setup):
  self.check_list.check_all()
  self.check_all_checked()
  self.check_list.uncheck_all()
  self.check_all_unchecked()
 
- def test_get_options(self):
+ def test_get_options(self, check_list_setup):
  Assert.assert_equal(self.check_list.get_options(), self.nature_options)
 
- def test_get_names(self):
+ def test_get_names(self, check_list_setup):
  Assert.assert_equal(self.check_list.get_names(), self.nature_options)
 
- def test_get_values(self):
+ def test_get_values(self, check_list_setup):
  Assert.assert_equal(self.check_list.get_values(), self.nature_options)
 
- def test_get_options_as_text(self):
+ def test_get_options_as_text(self, check_list_setup):
  Assert.assert_equal(self.check_list.get_options_as_text(), self.all_values)
 
- def test_set_value(self):
+ def test_set_value(self, check_list_setup):
  self.check_list.set_value("Fire")
  CommonActionsData.check_action(FIRE_MSG)
 
- def test_get_name(self):
+ def test_get_name(self, check_list_setup):
  Assert.assert_equal(self.check_list.get_name(), "nature_check_list")
 
- def test_are_selected(self):
+ def test_are_selected(self, check_list_setup):
  Assert.assert_equal(self.check_list.are_selected(), [])
 
- def test_are_deselected(self):
+ def test_are_deselected(self, check_list_setup):
  Assert.assert_equal(self.check_list.are_deselected(), self.nature_options)
 
- def test_get_value(self):
+ def test_get_value(self, check_list_setup):
  Assert.assert_equal(self.check_list.get_value(), None)
 
  def check_all_checked(self):
@@ -135,7 +132,3 @@ def check_all_unchecked(self):
  els = driver.find_elements(By.CSS_SELECTOR, value="#elements-checklist input")
  for el in els:
  Assert.assert_true(el.get_attribute("checked") in ["false", None])
-
-
-if __name__ == "__main__":
- unittest.main()