Skip to content

Conversation

@STRd6
Copy link
Contributor

@STRd6 STRd6 commented Apr 17, 2022

In theory setting these .gitattributes should prevent generated files from showing up in diffs by default.

https://github.com/github/linguist/tree/47b109be3657fe3d5933fba6840a6ceea0f94498#generated-file-detection

@GeoffreyBooth
Copy link
Collaborator

I think that’s already happening. If you look at https://github.com/jashkenas/coffeescript/pull/5403/files, all the .js files have a “Load diff” link, and the diff is hidden by default. Does adding this setting change anything?

We can always add this file and find out, as this doesn’t hurt anything, but I expect it won’t make a difference.

@STRd6
Copy link
Contributor Author

STRd6 commented Apr 18, 2022

I think you're right, this doesn't seem like it would improve anything.

@STRd6 STRd6 closed this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants