Report browser test errors #5408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
# and Puppeteer 3 only supports Node >= 10.18.1, so limit this test to those # versions. The code below uses `Promise.prototype.finally` because the # CoffeeScript codebase currently maintains compatibility with Node 6, which # did not support `async`/`await` syntax. Even though this test doesn’t run # in Node 6, it needs to still _parse_ in Node 6 so that this file can load.This was true when I wrote it years ago, but I think that by now we can drop support for EOL versions of Node at least for internal stuff like running tests. (The compiled output, I’m not so sure about.) So we could just rewrite this function to use Anyway I’m happy to merge in this PR as is, too, if you’d rather not spend any more time on it. |
Removed comment and check for older versions of Node as we no longer support them anymore.
Collaborator
| FYI: https://github.com/jashkenas/coffeescript/runs/5842054989?check_suite_focus=true Should this have reported something other than |
Contributor Author
| It should probably report nothing in the case where result hasn't been filled. I'll add that. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When running browser tests sometimes they would fail and only print
null. I added a.catchto log any error that is thrown (could be a timeout or intermittent error). I also removed extra parentheses and increased the timeout to 60s.