Remove always true if check #5406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This check has always been true since Node 0.3.0. It was added here: jashkenas@c4a3e17 and seems to rely on the behavior of `Module#_compile` from before `require.extensions`. If `require.extensions` is ever removed (it is deprecated after all) then `CoffeeScript.run` will no longer work. It will pass CoffeeScript source code to `Module#_compile` which is doomed to fail. Browser code doesn't touch this path at all and is unaffected.
Contributor Author
| In digging through the source mapping nitty gritty I found this small oddity. I'd prefer to split off small self contained cleanup PRs when possible so that the eventual source mapping PR isn't totally massive and coupled with indirectly related cleanup. |
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This check has always been true since Node 0.3.0. It was added here: c4a3e17 and seems to rely on the behavior of
Module#_compilefrom beforerequire.extensions. Ifrequire.extensionsis ever removed (it is deprecated after all) thenCoffeeScript.runwill no longer work. It will pass CoffeeScript source code toModule#_compilewhich is doomed to fail.Browser code doesn't touch this path at all and is unaffected.