[Console] fix "data lost during stream conversion" with QuestionHelper

Author: nicolas-grekas

src/Symfony/Component/Console/Helper/QuestionHelper.php

@@ -462,10 +462,6 @@ private function validateAttempts(callable $interviewer, OutputInterface $output
  $error = null;
  $attempts = $question->getMaxAttempts();
 
- if (null === $attempts && !$this->isTty()) {
- $attempts = 1;
- }
-
  while (null === $attempts || $attempts--) {
  if (null !== $error) {
  $this->writeError($output, $error);
@@ -477,6 +473,8 @@ private function validateAttempts(callable $interviewer, OutputInterface $output
  throw $e;
  } catch (\Exception $error) {
  }
+
+ $attempts = $attempts ?? -(int) $this->isTty();
  }
 
  throw $error;
@@ -517,7 +515,7 @@ private function isTty(): bool
  return stream_isatty($inputStream);
  }
 
- if (!\function_exists('posix_isatty')) {
+ if (\function_exists('posix_isatty')) {
  return posix_isatty($inputStream);
  }