Add DuckDuckGo browser.

Author: fnando

.rubocop.yml

@@ -27,3 +27,9 @@ Style/Alias:
 
 Lint/RedundantCopDisableDirective:
  Enabled: false
+
+Metrics/AbcSize:
+ Enabled: false
+
+Metrics/CyclomaticComplexity:
+ Enabled: false

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Detect Mac-based platforms differently, depending on the version; "Mac OS X"
  will be returned for versions prior to 10.12, and "macOS" for newer versions.
 - Remove `Browser.modern_rules` and `Browser::Base#modern?`.
+- Add DuckDuckGo browser.
 
 # 3.0.3
 

README.md

@@ -25,6 +25,7 @@ browser = Browser.new("Some User Agent", accept_language: "en-us")
 browser.bot?
 browser.chrome?
 browser.core_media?
+browser.duck_duck_go?
 browser.edge? # Newest MS browser
 browser.electron? # Electron Framework
 browser.firefox?

lib/browser/base.rb

@@ -187,6 +187,11 @@ def opera_mini?(expected_version = nil)
  ua =~ /Opera Mini/ && detect_version?(full_version, expected_version)
  end
 
+ # Detect if browser is DuckDuckGo.
+ def duck_duck_go?(expected_version = nil)
+ ua =~ /DuckDuckGo/ && detect_version?(full_version, expected_version)
+ end
+
  def webkit_full_version
  ua[%r{AppleWebKit/([\d.]+)}, 1] || "0.0"
  end

lib/browser/browser.rb

@@ -30,6 +30,7 @@
 require_relative "yandex"
 require_relative "sputnik"
 require_relative "snapchat"
+require_relative "duck_duck_go"
 
 require_relative "bot"
 require_relative "bot/empty_user_agent_matcher"
@@ -70,6 +71,7 @@ def self.matchers
  Electron, # must be placed before Chrome and Safari
  Yandex, # must be placed before Chrome and Safari
  Sputnik, # must be placed before Chrome and Safari
+ DuckDuckGo, # must be placed before Chrome and Safari
  Chrome,
  Safari,
  MicroMessenger,

lib/browser/chrome.rb

@@ -21,9 +21,12 @@ def full_version
 
  def match?
  ua =~ /Chrome|CriOS/ &&
- ua !~ /PhantomJS|FxiOS|YaBrowser|SputnikBrowser|ArchiveBot/ &&
+ ua !~ /PhantomJS|FxiOS|ArchiveBot/ &&
  !opera? &&
- !edge?
+ !edge? &&
+ !duck_duck_go? &&
+ !yandex? &&
+ !sputnik?
  end
  end
 end

lib/browser/duck_duck_go.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module Browser
+ class DuckDuckGo < Base
+ def id
+ :duckduckgo
+ end
+
+ def name
+ "DuckDuckGo"
+ end
+
+ def full_version
+ ua[%r{DuckDuckGo/([\d.]+)}, 1] ||
+ "0.0"
+ end
+
+ def match?
+ ua =~ /DuckDuckGo/
+ end
+ end
+end

lib/browser/safari.rb

@@ -18,7 +18,13 @@ def full_version
  end
 
  def match?
- ua =~ /Safari/ && ua !~ /Chrome|CriOS|PhantomJS|FxiOS|YaBrowser/
+ ua =~ /Safari/ &&
+ ua !~ /PhantomJS|FxiOS/ &&
+ !edge? &&
+ !chrome? &&
+ !duck_duck_go? &&
+ !yandex? &&
+ !sputnik?
  end
  end
 end

test/ua.yml

@@ -32,6 +32,8 @@ CHROME: "Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_4; en-US) AppleWebKit/53
 CHROME_OS: "Mozilla/5.0 (X11; CrOS x86_64 3701.81.0) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.57 Safari/537.31."
 COREMEDIA: "Apple Mac OS X v10.6.4 CoreMedia v1.0.0.10F569"
 CUSTOM_APP: "Our App 0.0.1 (Linux; Android 4.0.3; HTC Ruby Build/IML74K; en_CA)"
+DUCKDUCKGO_BROWSER_IOS: "Mozilla/5.0 (iPhone; CPU iPhone OS 13_3_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148 DuckDuckGo/7"
+DUCKDUCKGO_BROWSER_ANDROID: Mozilla/5.0 (Linux; Android 10) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/78.0.3904.96 Mobile Safari/537.36 DuckDuckGo/5"
 ELECTRON: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Electron/1.4.12 Safari/537.36"
 FACEBOOK: Mozilla/5.0 (iPhone; CPU iPhone OS 10_3_3 like Mac OS X) AppleWebKit/603.3.8 (KHTML, like Gecko) Mobile/14G60 [FBAN/FBIOS;FBAV/135.0.0.45.90;FBBV/66877072;FBDV/iPhone9,3;FBMD/iPhone;FBSN/iOS;FBSV/10.3.3;FBSS/2;FBCR/AT&T;FBID/phone;FBLC/en_US;FBOP/5;FBRV/0]
 FACEBOOK_ANDROID: "Mozilla/5.0 (Linux; Android 9; ONEPLUS A6003 Build/PKQ1.180716.001; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/73.0.3683.90 Mobile Safari/537.36 [FB_IAB/FB4A;FBAV/214.0.0.43.83;]"

test/unit/duck_duck_go_test.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class DuckDuckGoTest < Minitest::Test
+ test "detects DuckDuckGo on iOS device" do
+ browser = Browser.new(Browser["DUCKDUCKGO_BROWSER_IOS"])
+ assert browser.duck_duck_go?
+ refute browser.safari?
+ refute browser.chrome?
+ assert browser.webkit?
+ assert_equal "DuckDuckGo", browser.name
+ assert_equal :duckduckgo, browser.id
+ end
+
+ test "detects DuckDuckGo on Android device" do
+ browser = Browser.new(Browser["DUCKDUCKGO_BROWSER_ANDROID"])
+ assert browser.duck_duck_go?
+ refute browser.safari?
+ refute browser.chrome?
+ assert_equal "DuckDuckGo", browser.name
+ assert_equal :duckduckgo, browser.id
+ end
+
+ test "detects correct version" do
+ browser = Browser.new(Browser["DUCKDUCKGO_BROWSER_IOS"])
+ assert_equal "7", browser.full_version
+ assert_equal "7", browser.version
+ end
+
+ test "detects version by range" do
+ browser = Browser.new(Browser["DUCKDUCKGO_BROWSER_IOS"])
+ assert browser.duck_duck_go?(%w[>=7 <8])
+ end
+end