Use rubocop-fnando.

Author: fnando

.rubocop.yml

@@ -1,6 +1,9 @@
 ---
+inherit_gem:
+ rubocop-fnando: .rubocop.yml
 
 AllCops:
+ TargetRubyVersion: 2.5
  Exclude:
  - bin/**/*
  - gemfiles/**/*
@@ -10,129 +13,17 @@ AllCops:
  - "*.gemspec"
  - config.ru
 
-Layout/DotPosition:
- EnforcedStyle: leading
-
-Layout/RescueEnsureAlignment:
- Enabled: false
-
-Layout/SpaceBeforeBlockBraces:
- EnforcedStyle: space
-
-Layout/SpaceInsideBlockBraces:
- EnforcedStyle: space
- SpaceBeforeBlockParameters: false
-
-Layout/SpaceInsideHashLiteralBraces:
- Enabled: false
-
-Metrics/AbcSize:
- Enabled: false
-
 Metrics/ClassLength:
  Enabled: false
 
-Metrics/CyclomaticComplexity:
- Enabled: false
-
 Metrics/LineLength:
  Max: 80
 
 Metrics/MethodLength:
  Enabled: false
 
-Metrics/ParameterLists:
- Enabled: false
-
-Naming/FileName:
- Enabled: false
-
-Naming/PredicateName:
- NamePrefixBlacklist:
- - is_
-
-Naming/UncommunicativeMethodParamName:
- Enabled: false
-
 Style/Alias:
  EnforcedStyle: prefer_alias_method
 
-Style/BlockDelimiters:
- Enabled: false
-
-Style/ClassCheck:
- EnforcedStyle: kind_of?
-
-Style/CollectionMethods:
- PreferredMethods:
- collect: map
- collect!: map!
- inject: reduce
- detect: find
- find_all: select
-
-Style/Documentation:
- Enabled: false
-
-Style/DoubleNegation:
- Enabled: false
-
-Style/Encoding:
- Enabled: false
-
-Style/FrozenStringLiteralComment:
- EnforcedStyle: always
-
-Style/IfUnlessModifier:
- Enabled: false
-
-Style/ModuleFunction:
- Enabled: false
-
-Style/OneLineConditional:
- Enabled: false
-
-Style/PercentLiteralDelimiters:
- PreferredDelimiters:
- "%": "[]"
- "%i": "[]"
- "%q": "[]"
- "%Q": "[]"
- "%r": "[]"
- "%s": "[]"
- "%w": "[]"
- "%W": "[]"
- "%x": "[]"
-
-Style/PerlBackrefs:
- Enabled: false
-
-Style/Proc:
- Enabled: false
-
-Style/RegexpLiteral:
- Enabled: false
-
-Style/SafeNavigation:
- Enabled: false
-
-Style/SingleLineBlockParams:
- Enabled: false
-
-Style/StringLiterals:
- EnforcedStyle: double_quotes
- SupportedStyles:
- - single_quotes
- - double_quotes
-
-Style/TrailingCommaInArrayLiteral:
- Enabled: false
-
-Style/TrailingCommaInHashLiteral:
- Enabled: false
-
-Style/VariableInterpolation:
- Enabled: false
-
-Style/WhileUntilModifier:
+Lint/RedundantCopDisableDirective:
  Enabled: false

browser.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "./lib/browser/version"
 
 Gem::Specification.new do |s|
@@ -19,13 +21,14 @@ Gem::Specification.new do |s|
  s.require_paths = ["lib"]
 
  s.add_development_dependency "bundler", ">= 0"
- s.add_development_dependency "rake"
- s.add_development_dependency "rails"
- s.add_development_dependency "rack-test"
  s.add_development_dependency "minitest"
+ s.add_development_dependency "minitest-autotest"
  s.add_development_dependency "minitest-utils"
  s.add_development_dependency "pry-meta"
- s.add_development_dependency "minitest-autotest"
- s.add_development_dependency "simplecov"
+ s.add_development_dependency "rack-test"
+ s.add_development_dependency "rails"
+ s.add_development_dependency "rake"
  s.add_development_dependency "rubocop"
+ s.add_development_dependency "rubocop-fnando"
+ s.add_development_dependency "simplecov"
 end

lib/browser/accept_language.rb

@@ -34,28 +34,26 @@ def name
  def code
  @code ||= begin
  code = part[/\A([^-;]+)/, 1]
- code.downcase if code
+ code&.downcase
  end
  end
 
  def region
  @region ||= begin
  region = part[/\A(?:.*?)-([^;-]+)/, 1]
- region.upcase if region
+ region&.upcase
  end
  end
 
  def quality
  @quality ||= begin
  Float(quality_value || 1.0)
- rescue ArgumentError
- 0.1
+  rescue ArgumentError
+  0.1
  end
  end
 
- private
-
- def quality_value
+ private def quality_value
  qvalue = part[/;q=([\d.]+)/, 1]
  qvalue = qvalue =~ /\A0\.0?\z/ ? "0.0" : qvalue
  qvalue = qvalue.gsub(/\.+/, ".") if qvalue

lib/browser/action_controller.rb

@@ -10,9 +10,7 @@ module ActionController
  helper_method(:browser) if respond_to?(:helper_method)
  end
 
- private
-
- def browser
+ private def browser
  @browser ||= Browser.new(
  request.headers["User-Agent"],
  accept_language: request.headers["Accept-Language"]

lib/browser/alipay.rb

@@ -11,7 +11,7 @@ def name
  end
 
  def full_version
- ua[%r[(?:AlipayClient)/([\d.]+)]i, 1] || "0.0"
+ ua[%r{(?:AlipayClient)/([\d.]+)}i, 1] || "0.0"
  end
 
  def match?

lib/browser/base.rb

@@ -193,7 +193,7 @@ def opera_mini?(expected_version = nil)
  end
 
  def webkit_full_version
- ua[%r[AppleWebKit/([\d.]+)], 1] || "0.0"
+ ua[%r{AppleWebKit/([\d.]+)}, 1] || "0.0"
  end
 
  def known?

lib/browser/blackberry.rb

@@ -11,8 +11,8 @@ def name
  end
 
  def full_version
- ua[%r[BlackBerry[\da-z]+/([\d.]+)], 1] ||
- ua[%r[Version/([\d.]+)], 1] ||
+ ua[%r{BlackBerry[\da-z]+/([\d.]+)}, 1] ||
+ ua[%r{Version/([\d.]+)}, 1] ||
  "0.0"
  end
 

lib/browser/bot.rb

@@ -50,21 +50,19 @@ def name
  self.class.bots.find {|key, _| downcased_ua.include?(key) }.last
  end
 
- private
-
- def bot_with_empty_ua?
+ private def bot_with_empty_ua?
  self.class.detect_empty_ua? && ua.strip == ""
  end
 
- def bot_exception?
+ private def bot_exception?
  self.class.bot_exceptions.any? {|key| downcased_ua.include?(key) }
  end
 
- def detect_bot?
+ private def detect_bot?
  self.class.bots.any? {|key, _| downcased_ua.include?(key) }
  end
 
- def downcased_ua
+ private def downcased_ua
  @downcased_ua ||= ua.downcase
  end
  end

lib/browser/chrome.rb

@@ -12,10 +12,10 @@ def name
 
  def full_version
  # Each regex on its own line to enforce precedence.
- ua[%r[Chrome/([\d.]+)], 1] ||
- ua[%r[CriOS/([\d.]+)], 1] ||
- ua[%r[Safari/([\d.]+)], 1] ||
- ua[%r[AppleWebKit/([\d.]+)], 1] ||
+ ua[%r{Chrome/([\d.]+)}, 1] ||
+ ua[%r{CriOS/([\d.]+)}, 1] ||
+ ua[%r{Safari/([\d.]+)}, 1] ||
+ ua[%r{AppleWebKit/([\d.]+)}, 1] ||
  "0.0"
  end
 

lib/browser/detect_version.rb

@@ -2,9 +2,7 @@
 
 module Browser
  module DetectVersion
- private
-
- def detect_version?(actual_version, expected_version)
+ private def detect_version?(actual_version, expected_version)
  return true unless expected_version
  return false if expected_version && !actual_version
 
@@ -17,8 +15,8 @@ def detect_version?(actual_version, expected_version)
  false
  end
 
- def parse_version(version)
- version.kind_of?(Numeric) ? version.to_s : version
+ private def parse_version(version)
+ version.is_a?(Numeric) ? version.to_s : version
  end
  end
 end