Fix iOS 10+ version detection (fnando#422)

Author: koesie10

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 - Handle Snapchat user agents that have a space or an empty string instead of a slash before the version.
+- Fix iOS 10+ version detection.
 - Add fallback versions for instagram and snapchat to avoid NoMethodErrors on unexpected user agents.
 
 ## 2.7.0

lib/browser/platform/ios.rb

@@ -4,7 +4,7 @@ module Browser
  class Platform
  class IOS < Base
  MATCHER = /(iPhone|iPad|iPod)/.freeze
- VERSION_MATCHER = /OS ((?<major>\d)_(?<minor>\d)_?(?<patch>\d)?)/.freeze
+ VERSION_MATCHER = /OS ((?<major>\d+)_(?<minor>\d+)_?(?<patch>\d+)?)/.freeze # rubocop:disable Metrics/LineLength
 
  def version
  matches = VERSION_MATCHER.match(ua)

test/ua.yml

@@ -66,6 +66,7 @@ IOS8: "Mozilla/5.0 (iPhone; CPU iPhone OS 8_0 like Mac OS X) AppleWebKit/600.1.4
 IOS8_1_2: 'Mozilla/5.0 (iPhone; CPU iPhone OS 8_1_2 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Version/8.0 Mobile/12B440 Safari/600.1.4'
 IOS8_3: 'Mozilla/5.0 (iPhone; CPU iPhone OS 8_3 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Version/8.0 Mobile/12F70 Safari/600.1.4'
 IOS9: "Mozilla/5.0 (iPad; CPU OS 9_0 like Mac OS X) AppleWebKit/601.1.17 (KHTML, like Gecko) Version/8.0 Mobile/13A175 Safari/600.1.4"
+IOS12: "Mozilla/5.0 (iPhone; CPU iPhone OS 12_0 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.0 Mobile/15E148 Safari/604.1"
 IOS_WEBVIEW: Mozilla/5.0 (iPhone; CPU iPhone OS 8_4 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Mobile/12H141
 IPAD: "Mozilla/5.0 (iPad; U; CPU OS 3_2 like Mac OS X; en-us) AppleWebKit/531.21.10 (KHTML, like Gecko) Version/4.0.4 Mobile/7B367 Safari/531.21.10"
 IPHONE: "Mozilla/5.0 (iPhone; U; CPU iPhone OS 3_0 like Mac OS X; en-us) AppleWebKit/420.1 (KHTML, like Gecko) Version/3.0 Mobile/1A542a Safari/419.3"

test/unit/ios_test.rb

@@ -105,6 +105,13 @@ class IosTest < Minitest::Test
  refute browser.platform.mac?
  end
 
+ test "detects ios12" do
+ browser = Browser.new(Browser["IOS12"])
+ assert browser.platform.ios?
+ assert browser.platform.ios?(12)
+ refute browser.platform.mac?
+ end
+
  test "don't detect as two different versions" do
  browser = Browser.new(Browser["IOS8"])
  assert browser.platform.ios?(8)