Big fix in first ticket add

Set default values of some columns on tickets table

Author: Kiril Kirkov

DATABASE.sql

@@ -215,18 +215,18 @@ CREATE TABLE IF NOT EXISTS `tickets` (
  `addedby` tinyint(4) NOT NULL,
  `message_uid` int(11) NOT NULL DEFAULT '0' COMMENT 'uid of message',
  `message_id` varchar(255) DEFAULT NULL,
- `message_from_email` varchar(255) NOT NULL,
- `message_from_name` varchar(255) NOT NULL,
- `message_attachments` varchar(255) NOT NULL,
- `message_to_email` varchar(255) NOT NULL,
- `send` tinyint(1) NOT NULL,
+ `message_from_email` varchar(255) DEFAULT NULL,
+ `message_from_name` varchar(255) DEFAULT NULL,
+ `message_attachments` varchar(255) DEFAULT NULL,
+ `message_to_email` varchar(255) DEFAULT NULL,
+ `send` tinyint(1) NOT NULL DEFAULT '0',
  `duedate` int(12) unsigned NOT NULL,
- `pph` varchar(10) NOT NULL,
- `pph_c` varchar(5) NOT NULL,
+ `pph` varchar(10) DEFAULT NULL,
+ `pph_c` varchar(5) DEFAULT NULL,
  `estimated_seconds` int(10) unsigned NOT NULL COMMENT 'estimated time in seconds',
  `timecreated` int(12) unsigned NOT NULL,
  `timeclosed` int(10) unsigned NOT NULL,
- `lastupdate` int(10) unsigned NOT NULL,
+ `lastupdate` int(10) unsigned DEFAULT NULL,
  PRIMARY KEY (`id`),
  KEY `status` (`status`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8 AUTO_INCREMENT=1 ;

_html_parts/tickets/newissue.php

@@ -145,7 +145,7 @@
  <label class="control-label col-sm-2" for="assignee"><?= $this->lang_php['assignee'] ?></label>
  <div class="col-sm-10">
  <select class="selectpicker form-control show-tick show-menu-arrow" name="assignee" id="assignee">
- <option></option>
+ <option value="0"></option>
  <?php foreach ($users as $user) { ?>
  <option <?= isset($_POST['assignee']) && $_POST['assignee'] == $user['id'] ? 'selected' : '' ?> value="<?= $user['id'] ?>"><?= $user['fullname'] ?></option>
  <?php } ?>

classes/class.database.php

@@ -395,6 +395,9 @@ public function setTicket($post, $update) {
  $post['subject'] = mb_substr($post['subject'], 0, 200);
  }
  $post['estimated_seconds'] = strtotime($post['estimated_days'] . ' day ' . $post['estimated_hours'] . ' hour ' . $post['estimated_minutes'] . ' minute', 0);
+ if($post['estimated_seconds'] === false) {
+ $post['estimated_seconds'] = 0;
+ }
  unset($post['estimated_days']);
  unset($post['estimated_hours']);
  unset($post['estimated_minutes']);

inc/helpers.php

@@ -98,10 +98,12 @@ function word_limiter($word, $limit_to, $start_from = 0) {
 }
 
 function secondsToTime($seconds, $want_array = false) {
- if ($seconds < 0)
+ if ($seconds < 0) {
  $minus = '- ';
- else
+ }
+ else {
  $minus = '';
+ }
  $dtF = new DateTime("@0");
  $dtT = new DateTime("@$seconds");
  if ($want_array === false) {