Skip to content

Conversation

@RosaWagner
Copy link

@RosaWagner RosaWagner commented Sep 1, 2023

Hi, there is the build for the static ttf with manual TThinting.

  • removed "quadratic" from the ufo files name (hence the number of changed files)
  • renamed "other files" dir to "tt-hinting" for more clarity and removed spaces in directory names.
  • generated ttx files out of the tt-hinting sources
  • fixed some reported inconsistencies between the quadratic source ufos and the tt hinting instructions in the ttf files. Only the ttf were corrected, not the ufos:
    • vttLib.VTTLibInvalidComposite: Component 1 in 'Wcircumflex' has wrong x offset: expected 306, found 307. (Bold Italic, Medium Italic)
    • vttLib.VTTLibInvalidComposite: Component 1 in 'uacute' has wrong x offset: expected 309, found 305. (Bold Italic)
    • vttLib.VTTLibInvalidComposite: Component 1 in 'uacute' has wrong y offset: expected -5, found -9. (Bold Italic)
    • vttLib.VTTLibInvalidComposite: Component 1 in 'ugrave' has wrong x offset: expected 309, found 305. (Bold Italic)
    • vttLib.VTTLibInvalidComposite: Component 1 in 'ugrave' has wrong y offset: expected -5, found -9. (Bold Italic)
  • removed duplicated component in Ldot
  • Adjusted winAscent and winDescent to avoid clipping in browsers (use_typo_metrics is enabled so this doesn't change the actual linespacing, cf https://googlefonts.github.io/gf-guide/metrics.html)
  • The last inconsistency remains now in the copyright notice. It was implemented as GF would expect in the fonts but not in OFL.txt. We can discuss it again by email. Edit: Fixed copyright string and license URL.

Note:
The RIBBI styles don't need nameID16 and 17 ("typographic names") because they are duplicated from nameID1 and 2. We currently have a FAIL in fontbakery for this (from Adobe profile). We can eventually ignore it if you insist on keeping them, but I would recommend to remove them for the four RIBBI styles.

Build instruction to add in the readme:

  1. install gftool python packages (preferably in a virtual environment): pip install gftools
  2. to build ttf binaries with manual TT-hinting, from the sources file directory: gftools builder config.yaml
@RosaWagner RosaWagner mentioned this pull request Sep 8, 2023
9 tasks
@RosaWagner RosaWagner closed this by deleting the head repository Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant