Skip to content

Commit 37f410c

Browse files
authored
fix coverity issues (#3753)
1 parent cf6d888 commit 37f410c

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

intel_extension_for_pytorch/quantization/_quantize.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ def _float_module(cls):
238238
LinearLayer = deepspeed_modules[1]
239239
_FLOAT_MODULE.extend([LinearLayer])
240240

241-
if len(deepspeed_modules) > 3:
241+
if deepspeed_modules is not None and len(deepspeed_modules) > 3:
242242
for module in deepspeed_modules[3:]:
243243
if issubclass(module, LinearLayer):
244244
_FLOAT_MODULE.extend([module])

intel_extension_for_pytorch/transformers/models/reference/models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1309,6 +1309,7 @@ def OPTDecoder_forward(
13091309
# embed positions
13101310

13111311
if position_ids is None:
1312+
assert attention_mask is not None
13121313
position_ids = torch.cumsum(attention_mask, dim=1)
13131314
position_ids = (position_ids * attention_mask - 1).long()
13141315
# cut positions if `past_key_values_length` is > 0

tests/cpu/hf_configs/phi4/speech_conformer_encoder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -885,6 +885,7 @@ def _bucket_relative_position(self, relative_position):
885885
# this is a placeholder (isn't tested, likely buggy) using HuggingFace implem as a reference
886886
# this also needs to be extended to support asymmetric +/- ve positions
887887
relative_buckets = 0
888+
num_buckets = self.num_buckets
888889
if not self.causal:
889890
num_buckets //= 2
890891
relative_buckets += (relative_position > 0).to(torch.long) * num_buckets
@@ -893,7 +894,6 @@ def _bucket_relative_position(self, relative_position):
893894
relative_position = -torch.min(
894895
relative_position, torch.zeros_like(relative_position)
895896
)
896-
num_buckets = self.num_buckets
897897
# now relative_position is in the range [0, inf)
898898

899899
# half of the buckets are for exact increments in positions

0 commit comments

Comments
 (0)