Skip to content

Commit eec2054

Browse files
venkatesh921Yogaraj-Alamenda
authored andcommitted
Remove QATerr statements from bind_qat().
- Fix linker error with IPsec_mb and remove openssl/aes.h header Signed-off-by: Yogaraj Alamenda <yogarajx.alamenda@intel.com>
1 parent 497de5f commit eec2054

File tree

6 files changed

+553
-620
lines changed

6 files changed

+553
-620
lines changed

configure.ac

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ then
335335
then
336336
with_qat_sw_install_dir="/usr/local"
337337
AC_SUBST([cflags_qat_sw], ["-DQAT_SW"])
338-
AC_SUBST([QAT_SW_CRYPTO_MB_LIB], ["-Wl,-rpath,\$(with_qat_sw_install_dir)/lib -L\$(with_qat_sw_install_dir)/lib -lcrypto_mb -lIPSec_MB"])
338+
AC_SUBST([QAT_SW_CRYPTO_MB_LIB], ["-Wl,-rpath,\$(with_qat_sw_install_dir)/lib -L\$(with_qat_sw_install_dir)/lib -lcrypto_mb"])
339339
fi
340340
if test "x$ac_cv_lib_IPSec_MB_imb_get_version" = "xyes"
341341
then

e_qat.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -863,26 +863,22 @@ static int bind_qat(ENGINE *e, const char *id)
863863
#if defined(QAT_HW) && !defined(QAT_HW_INTREE)
864864
if (access(QAT_DEV, F_OK) != 0) {
865865
WARN("Qat memory driver not present\n");
866-
QATerr(QAT_F_BIND_QAT, QAT_R_MEM_DRV_NOT_PRESENT);
867866
goto end;
868867
}
869868
#endif
870869

871870
if (id && (strcmp(id, engine_qat_id) != 0)) {
872871
WARN("ENGINE_id defined already! %s - %s\n", id, engine_qat_id);
873-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_ID_ALREADY_DEFINED);
874872
goto end;
875873
}
876874

877875
if (!ENGINE_set_id(e, engine_qat_id)) {
878876
WARN("ENGINE_set_id failed\n");
879-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_SET_ID_FAILURE);
880877
goto end;
881878
}
882879

883880
if (!ENGINE_set_name(e, engine_qat_name)) {
884881
WARN("ENGINE_set_name failed\n");
885-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_SET_NAME_FAILURE);
886882
goto end;
887883
}
888884

@@ -903,31 +899,26 @@ static int bind_qat(ENGINE *e, const char *id)
903899

904900
if (!ENGINE_set_RSA(e, qat_get_RSA_methods())) {
905901
WARN("ENGINE_set_RSA failed\n");
906-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_SET_RSA_FAILURE);
907902
goto end;
908903
}
909904

910905
if (!ENGINE_set_DSA(e, qat_get_DSA_methods())) {
911906
WARN("ENGINE_set_DSA failed\n");
912-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_SET_DSA_FAILURE);
913907
goto end;
914908
}
915909

916910
if (!ENGINE_set_DH(e, qat_get_DH_methods())) {
917911
WARN("ENGINE_set_DH failed\n");
918-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_SET_DH_FAILURE);
919912
goto end;
920913
}
921914

922915
if (!ENGINE_set_EC(e, qat_get_EC_methods())) {
923916
WARN("ENGINE_set_EC failed\n");
924-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_SET_EC_FAILURE);
925917
goto end;
926918
}
927919

928920
if (!ENGINE_set_pkey_meths(e, qat_pkey_methods)) {
929921
WARN("ENGINE_set_pkey_meths failed\n");
930-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_SET_PKEY_FAILURE);
931922
goto end;
932923
}
933924
# ifdef QAT_INTREE
@@ -943,15 +934,13 @@ static int bind_qat(ENGINE *e, const char *id)
943934
DEBUG("Multibuffer RSA Supported\n");
944935
if (!ENGINE_set_RSA(e, multibuff_get_RSA_methods())) {
945936
WARN("ENGINE_set_RSA failed\n");
946-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_SET_RSA_FAILURE);
947937
goto end;
948938
}
949939
}
950940
if (mbx_get_algo_info(MBX_ALGO_X25519)) {
951941
DEBUG("Multibuffer ECDH X25519 Supported\n");
952942
if (!ENGINE_set_pkey_meths(e, multibuff_x25519_pkey_methods)) {
953943
WARN("ENGINE_set_pkey_meths failed\n");
954-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_SET_X25519_FAILURE);
955944
goto end;
956945
}
957946
}
@@ -963,7 +952,6 @@ static int bind_qat(ENGINE *e, const char *id)
963952
DEBUG("Multibuffer ECDSA p256/p384 & ECDH p256/p384 Supported\n");
964953
if (!ENGINE_set_EC(e, mb_get_EC_methods())) {
965954
WARN("ENGINE_set_EC failed\n");
966-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_SET_EC_FAILURE);
967955
goto end;
968956
}
969957
}
@@ -973,13 +961,11 @@ static int bind_qat(ENGINE *e, const char *id)
973961
#ifdef QAT_SW_IPSEC
974962
if (!hw_support()) {
975963
WARN("The Processor does not support the features needed for VAES.\n");
976-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_HW_NOT_SUPPORTED);
977964
goto end;
978965
}
979966
# ifndef DISABLE_QAT_SW_GCM
980967
if (!vaesgcm_init_ipsec_mb_mgr()) {
981968
WARN("IPSec Multi-Buffer Manager Initialization failed\n");
982-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_SET_GCM_CIPHERS_FAILURE);
983969
goto end;
984970
}
985971
# endif
@@ -988,7 +974,6 @@ static int bind_qat(ENGINE *e, const char *id)
988974
#if defined(QAT_HW) || defined(QAT_SW_IPSEC)
989975
if (!ENGINE_set_ciphers(e, qat_ciphers)) {
990976
WARN("ENGINE_set_ciphers failed\n");
991-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_SET_CIPHER_FAILURE);
992977
goto end;
993978
}
994979
#endif
@@ -1004,7 +989,6 @@ static int bind_qat(ENGINE *e, const char *id)
1004989
ret &= ENGINE_set_cmd_defns(e, qat_cmd_defns);
1005990
if (ret == 0) {
1006991
WARN("Engine failed to register init, finish or destroy functions\n");
1007-
QATerr(QAT_F_BIND_QAT, QAT_R_ENGINE_REGISTER_FUNC_FAILURE);
1008992
}
1009993

1010994
/*

0 commit comments

Comments
 (0)