Remove reaper thread from global config, Netty now uses a HashedWheelTimer, close AsyncHttpClient#331

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/AsyncHttpClientConfig.java

@@ -88,7 +88,6 @@ public class AsyncHttpClientConfig {
  protected boolean compressionEnabled;
  protected String userAgent;
  protected boolean allowPoolingConnection;
- protected ScheduledExecutorService reaper;
  protected ExecutorService applicationThreadPool;
  protected ProxyServerSelector proxyServerSelector;
  protected SSLContext sslContext;
@@ -179,7 +178,6 @@ private AsyncHttpClientConfig(int maxTotalConnections,
  this.ioExceptionFilters = ioExceptionFilters;
  this.requestCompressionLevel = requestCompressionLevel;
  this.maxRequestRetry = maxRequestRetry;
- this.reaper = reaper;
  this.allowSslConnectionPool = allowSslConnectionCaching;
  this.removeQueryParamOnRedirect = removeQueryParamOnRedirect;
  this.hostnameVerifier = hostnameVerifier;
@@ -196,15 +194,6 @@ private AsyncHttpClientConfig(int maxTotalConnections,
  this.asyncConnectMode = asyncConnectMode;
  }
 
- /**
- * A {@link ScheduledExecutorService} used to expire idle connections.
- *
- * @return {@link ScheduledExecutorService}
- */
- public ScheduledExecutorService reaper() {
- return reaper;
- }
-
  /**
  * Return the maximum number of connections an {@link AsyncHttpClient} can handle.
  *
@@ -516,7 +505,7 @@ public boolean isValid() {
  // when using a ManagedExecutorService.
  // When this is the case, we assume it's running.
  }
- return (atpRunning && !reaper.isShutdown());
+ return atpRunning;
  }
 
  /**
@@ -1194,7 +1183,6 @@ public Builder(AsyncHttpClientConfig prototype) {
  userAgent = prototype.getUserAgent();
  redirectEnabled = prototype.isRedirectEnabled();
  compressionEnabled = prototype.isCompressionEnabled();
- reaper = prototype.reaper();
  applicationThreadPool = prototype.executorService();
 
  requestFilters.clear();

providers/netty/src/main/java/org/asynchttpclient/providers/netty/NettyAsyncHttpProvider.java

@@ -65,7 +65,6 @@ public void close() {
  if (closed.compareAndSet(false, true)) {
  try {
  channels.close();
- config.reaper().shutdown();
  } catch (Throwable t) {
  LOGGER.warn("Unexpected error on close", t);
  }