Add some final vars

Author: Stephane Landelle

providers/netty/src/main/java/org/asynchttpclient/providers/netty/handler/HttpProtocol.java

@@ -393,7 +393,7 @@ public void handle(final Channel channel, final NettyResponseFuture<?> future, f
  ByteBuf buf = chunk.content();
  try {
  if (!interrupt && (buf.readableBytes() > 0 || last)) {
- interrupt = updateBodyAndInterrupt(future, handler, bodyPartFactory.newResponseBodyPart(buf, last));
+ interrupt = updateBodyAndInterrupt(future, handler, nettyConfig.getBodyPartFactory().newResponseBodyPart(buf, last));
  }
  } finally {
  // FIXME we shouldn't need this, should we? But a leak was reported there without it?!
@@ -406,7 +406,7 @@ public void handle(final Channel channel, final NettyResponseFuture<?> future, f
  }
  }
  } catch (Exception t) {
- if (t instanceof IOException && !config.getIOExceptionFilters().isEmpty()
+ if (hasIOExceptionFilters && t instanceof IOException
  && requestSender.applyIoExceptionFiltersAndReplayRequest(future, IOException.class.cast(t), channel)) {
  return;
  }

providers/netty/src/main/java/org/asynchttpclient/providers/netty/handler/Protocol.java

@@ -40,7 +40,6 @@
 import org.asynchttpclient.org.jboss.netty.handler.codec.http.CookieDecoder;
 import org.asynchttpclient.providers.netty.Callback;
 import org.asynchttpclient.providers.netty.NettyAsyncHttpProviderConfig;
-import org.asynchttpclient.providers.netty.NettyAsyncHttpProviderConfig.ResponseBodyPartFactory;
 import org.asynchttpclient.providers.netty.channel.Channels;
 import org.asynchttpclient.providers.netty.future.NettyResponseFuture;
 import org.asynchttpclient.providers.netty.request.NettyRequestSender;
@@ -54,14 +53,20 @@ public abstract class Protocol {
 
  protected final Channels channels;
  protected final AsyncHttpClientConfig config;
+ protected final NettyAsyncHttpProviderConfig nettyConfig;
  protected final NettyRequestSender requestSender;
- protected final ResponseBodyPartFactory bodyPartFactory;
+
+ private final boolean hasResponseFilters;
+ protected final boolean hasIOExceptionFilters;
 
  public Protocol(Channels channels, AsyncHttpClientConfig config, NettyAsyncHttpProviderConfig nettyConfig, NettyRequestSender requestSender) {
  this.channels = channels;
  this.config = config;
  this.requestSender = requestSender;
- this.bodyPartFactory = nettyConfig.getBodyPartFactory();
+ this.nettyConfig = nettyConfig;
+
+ hasResponseFilters = !config.getResponseFilters().isEmpty();
+ hasIOExceptionFilters = !config.getIOExceptionFilters().isEmpty();
  }
 
  public abstract void handle(Channel channel, NettyResponseFuture<?> future, Object message) throws Exception;
@@ -154,7 +159,7 @@ public void call() throws Exception {
  protected boolean handleResponseFiltersReplayRequestAndExit(Channel channel, NettyResponseFuture<?> future, HttpResponseStatus status, HttpResponseHeaders responseHeaders)
  throws IOException {
 
- if (!config.getResponseFilters().isEmpty()) {
+ if (hasResponseFilters) {
  AsyncHandler<?> handler = future.getAsyncHandler();
  FilterContext fc = new FilterContext.FilterContextBuilder().asyncHandler(handler).request(future.getRequest()).responseStatus(status).responseHeaders(responseHeaders)
  .build();

providers/netty/src/main/java/org/asynchttpclient/providers/netty/handler/WebSocketProtocol.java

@@ -141,7 +141,7 @@ public void handle(Channel channel, NettyResponseFuture<?> future, Object e) thr
  ByteBuf buf = frame.content();
  if (buf != null && buf.readableBytes() > 0) {
  try {
- NettyResponseBodyPart rp = bodyPartFactory.newResponseBodyPart(buf, frame.isFinalFragment());
+ NettyResponseBodyPart rp = nettyConfig.getBodyPartFactory().newResponseBodyPart(buf, frame.isFinalFragment());
  h.onBodyPartReceived(rp);
 
  if (binaryFrame) {