Declaration emit should avoid issuing errors on unresolved names (microsoft#58536)

Author: weswigham

src/compiler/checker.ts

@@ -5864,7 +5864,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
 
  // Verify if the symbol is accessible
  return (symbol && hasVisibleDeclarations(symbol, shouldComputeAliasToMakeVisible)) || {
- accessibility: SymbolAccessibility.NotAccessible,
+ accessibility: SymbolAccessibility.NotResolved,
  errorSymbolName: getTextOfNode(firstIdentifier),
  errorNode: firstIdentifier,
  };

src/compiler/transformers/declarations.ts

@@ -324,7 +324,8 @@ export function transformDeclarations(context: TransformationContext) {
  }
  // TODO: Do all these accessibility checks inside/after the first pass in the checker when declarations are enabled, if possible
  }
- else {
+ // The checker should issue errors on unresolvable names, skip the declaration emit error for using a private/unreachable name for those
+ else if (symbolAccessibilityResult.accessibility !== SymbolAccessibility.NotResolved) {
  // Report error
  const errorInfo = getSymbolAccessibilityDiagnostic(symbolAccessibilityResult);
  if (errorInfo) {

src/compiler/types.ts

@@ -5544,6 +5544,7 @@ export const enum SymbolAccessibility {
  Accessible,
  NotAccessible,
  CannotBeNamed,
+ NotResolved,
 }
 
 /** @internal */

tests/baselines/reference/accessorDeclarationEmitVisibilityErrors.errors.txt

@@ -1,12 +1,9 @@
 accessorDeclarationEmitVisibilityErrors.ts(2,18): error TS2304: Cannot find name 'DoesNotExist'.
-accessorDeclarationEmitVisibilityErrors.ts(2,18): error TS4106: Parameter 'arg' of accessor has or is using private name 'DoesNotExist'.
 
 
-==== accessorDeclarationEmitVisibilityErrors.ts (2 errors) ====
+==== accessorDeclarationEmitVisibilityErrors.ts (1 errors) ====
  export class Q {
  set bet(arg: DoesNotExist) {}
  ~~~~~~~~~~~~
 !!! error TS2304: Cannot find name 'DoesNotExist'.
- ~~~~~~~~~~~~
-!!! error TS4106: Parameter 'arg' of accessor has or is using private name 'DoesNotExist'.
  }

tests/baselines/reference/accessorDeclarationEmitVisibilityErrors.js

@@ -9,3 +9,9 @@ export class Q {
 export class Q {
  set bet(arg) { }
 }
+
+
+//// [accessorDeclarationEmitVisibilityErrors.d.ts]
+export declare class Q {
+ set bet(arg: DoesNotExist);
+}

tests/baselines/reference/declarationEmitExpressionInExtends4.errors.txt

@@ -1,10 +1,9 @@
 declarationEmitExpressionInExtends4.ts(5,17): error TS2315: Type 'D' is not generic.
 declarationEmitExpressionInExtends4.ts(9,18): error TS2304: Cannot find name 'SomeUndefinedFunction'.
 declarationEmitExpressionInExtends4.ts(14,18): error TS2304: Cannot find name 'SomeUndefinedFunction'.
-declarationEmitExpressionInExtends4.ts(14,18): error TS4020: 'extends' clause of exported class 'C3' has or is using private name 'SomeUndefinedFunction'.
 
 
-==== declarationEmitExpressionInExtends4.ts (4 errors) ====
+==== declarationEmitExpressionInExtends4.ts (3 errors) ====
  function getSomething() {
  return class D { }
  }
@@ -25,7 +24,5 @@ declarationEmitExpressionInExtends4.ts(14,18): error TS4020: 'extends' clause of
  class C3 extends SomeUndefinedFunction {
  ~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2304: Cannot find name 'SomeUndefinedFunction'.
- ~~~~~~~~~~~~~~~~~~~~~
-!!! error TS4020: 'extends' clause of exported class 'C3' has or is using private name 'SomeUndefinedFunction'.
 
  }

tests/baselines/reference/declarationEmitExpressionInExtends4.js

@@ -62,3 +62,19 @@ var C3 = /** @class */ (function (_super) {
  }
  return C3;
 }(SomeUndefinedFunction));
+
+
+//// [declarationEmitExpressionInExtends4.d.ts]
+declare function getSomething(): {
+ new (): {};
+};
+declare const C_base: {
+ new (): {};
+};
+declare class C extends C_base<number, string> {
+}
+declare const C2_base: any;
+declare class C2 extends C2_base<number, string> {
+}
+declare class C3 extends SomeUndefinedFunction {
+}

tests/baselines/reference/declarationEmitExpressionInExtends7.errors.txt

@@ -1,11 +1,8 @@
 declarationEmitExpressionInExtends7.ts(1,30): error TS2304: Cannot find name 'SomeUndefinedFunction'.
-declarationEmitExpressionInExtends7.ts(1,30): error TS4021: 'extends' clause of exported class has or is using private name 'SomeUndefinedFunction'.
 
 
-==== declarationEmitExpressionInExtends7.ts (2 errors) ====
+==== declarationEmitExpressionInExtends7.ts (1 errors) ====
  export default class extends SomeUndefinedFunction {}
  ~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2304: Cannot find name 'SomeUndefinedFunction'.
- ~~~~~~~~~~~~~~~~~~~~~
-!!! error TS4021: 'extends' clause of exported class has or is using private name 'SomeUndefinedFunction'.
 

tests/baselines/reference/declarationEmitExpressionInExtends7.js

@@ -30,3 +30,8 @@ var default_1 = /** @class */ (function (_super) {
  return default_1;
 }(SomeUndefinedFunction));
 exports.default = default_1;
+
+
+//// [declarationEmitExpressionInExtends7.d.ts]
+export default class extends SomeUndefinedFunction {
+}

tests/baselines/reference/declarationEmitIndexTypeNotFound.errors.txt

@@ -1,16 +1,13 @@
 declarationEmitIndexTypeNotFound.ts(2,6): error TS1268: An index signature parameter type must be 'string', 'number', 'symbol', or a template literal type.
 declarationEmitIndexTypeNotFound.ts(2,13): error TS2304: Cannot find name 'TypeNotFound'.
-declarationEmitIndexTypeNotFound.ts(2,13): error TS4092: Parameter 'index' of index signature from exported interface has or is using private name 'TypeNotFound'.
 
 
-==== declarationEmitIndexTypeNotFound.ts (3 errors) ====
+==== declarationEmitIndexTypeNotFound.ts (2 errors) ====
  export interface Test {
  [index: TypeNotFound]: any;
  ~~~~~
 !!! error TS1268: An index signature parameter type must be 'string', 'number', 'symbol', or a template literal type.
  ~~~~~~~~~~~~
 !!! error TS2304: Cannot find name 'TypeNotFound'.
- ~~~~~~~~~~~~
-!!! error TS4092: Parameter 'index' of index signature from exported interface has or is using private name 'TypeNotFound'.
  }