Skip to content

Commit a5036cc

Browse files
authored
Fix sba-alert's rendering in absence of an error (codecentric#1795)
1 parent c5ec088 commit a5036cc

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

spring-boot-admin-server-ui/src/main/frontend/components/sba-alert.spec.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,18 @@ describe('sba-alert', () => {
3333
expect(screen.getByText('i am a error message')).toBeDefined();
3434
expect(screen.getByText('This is a caption')).toBeDefined();
3535
});
36+
37+
it('should render nothing', () => {
38+
const props = {
39+
title: 'This is a caption',
40+
}
41+
render(sbaAlert, {
42+
props,
43+
stubs: {
44+
'font-awesome-icon': true
45+
}
46+
});
47+
48+
expect(screen.queryByText('This is a caption')).not.toBeInTheDocument();
49+
});
3650
})

spring-boot-admin-server-ui/src/main/frontend/components/sba-alert.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
-->
1616

1717
<template>
18-
<div class="message" :class="alertClass" role="alert" v-if="hasError">
18+
<div class="message" :class="alertClass" role="alert" v-if="hasError()">
1919
<div class="message-body">
2020
<strong>
2121
<font-awesome-icon :class="iconClass" icon="exclamation-triangle" />&nbsp;<span v-text="title" />

0 commit comments

Comments
 (0)