Removed old telemetry and old way of searching for jupyter (microsoft#11198)

* Removed old telemetry and old code * News * Oops * Remove redundant tests * Fix failing test

Author: DonJayamanne

news/3 Code Health/10809.md

@@ -0,0 +1 @@
+Remove deprecated telemetry and old way of searching for `Jupyter`.

src/client/datascience/constants.ts

@@ -216,7 +216,6 @@ export enum Telemetry {
  OpenPlotViewer = 'DATASCIENCE.OPEN_PLOT_VIEWER',
  DebugCurrentCell = 'DATASCIENCE.DEBUG_CURRENT_CELL',
  CodeLensAverageAcquisitionTime = 'DS_INTERNAL.CODE_LENS_ACQ_TIME',
- ClassConstructionTime = 'DS_INTERNAL.CLASS_CONSTRUCTION_TIME',
  FindJupyterCommand = 'DS_INTERNAL.FIND_JUPYTER_COMMAND',
  /**
  * Telemetry sent when user selects an interpreter to be used for starting of Jupyter server.

src/client/datascience/jupyter/interpreter/jupyterCommandFinder.ts

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 'use strict';
 import { IExtensionSingleActivationService } from '../activation/types';
-import { IApplicationEnvironment, IWorkspaceService } from '../common/application/types';
+import { IApplicationEnvironment } from '../common/application/types';
 import { UseCustomEditorApi } from '../common/constants';
 import { IServiceManager } from '../ioc/types';
 import { Activation } from './activation';
@@ -48,9 +48,6 @@ import { IPyWidgetMessageDispatcherFactory } from './ipywidgets/ipyWidgetMessage
 import { IPyWidgetScriptSource } from './ipywidgets/ipyWidgetScriptSource';
 import { JupyterCommandLineSelector } from './jupyter/commandLineSelector';
 import { JupyterCommandFactory } from './jupyter/interpreter/jupyterCommand';
-import { JupyterCommandFinder } from './jupyter/interpreter/jupyterCommandFinder';
-import { JupyterCommandInterpreterDependencyService } from './jupyter/interpreter/jupyterCommandInterpreterDependencyService';
-import { JupyterCommandFinderInterpreterExecutionService } from './jupyter/interpreter/jupyterCommandInterpreterExecutionService';
 import { JupyterInterpreterDependencyService } from './jupyter/interpreter/jupyterInterpreterDependencyService';
 import { JupyterInterpreterOldCacheStateStore } from './jupyter/interpreter/jupyterInterpreterOldCacheStateStore';
 import { JupyterInterpreterSelectionCommand } from './jupyter/interpreter/jupyterInterpreterSelectionCommand';
@@ -189,7 +186,6 @@ export function registerTypes(serviceManager: IServiceManager) {
  serviceManager.addSingleton<IPlotViewerProvider>(IPlotViewerProvider, PlotViewerProvider);
  serviceManager.addSingleton<IStatusProvider>(IStatusProvider, StatusProvider);
  serviceManager.addSingleton<IThemeFinder>(IThemeFinder, ThemeFinder);
- serviceManager.addSingleton<JupyterCommandFinder>(JupyterCommandFinder, JupyterCommandFinder);
  serviceManager.addSingleton<JupyterCommandLineSelector>(JupyterCommandLineSelector, JupyterCommandLineSelector);
  serviceManager.addSingleton<JupyterCommandLineSelectorCommand>(JupyterCommandLineSelectorCommand, JupyterCommandLineSelectorCommand);
  serviceManager.addSingleton<JupyterInterpreterDependencyService>(JupyterInterpreterDependencyService, JupyterInterpreterDependencyService);
@@ -211,16 +207,8 @@ export function registerTypes(serviceManager: IServiceManager) {
  serviceManager.addSingleton<IJupyterServerProvider>(IJupyterServerProvider, NotebookServerProvider);
  serviceManager.add<IJMPConnection>(IJMPConnection, EnchannelJMPConnection);
  serviceManager.addSingleton<IPyWidgetMessageDispatcherFactory>(IPyWidgetMessageDispatcherFactory, IPyWidgetMessageDispatcherFactory);
-
- // Temporary code, to allow users to revert to the old behavior.
- const cfg = serviceManager.get<IWorkspaceService>(IWorkspaceService).getConfiguration('python.dataScience', undefined);
- if (cfg.get<boolean>('useOldJupyterServer', false)) {
- serviceManager.addSingleton<IJupyterInterpreterDependencyManager>(IJupyterInterpreterDependencyManager, JupyterCommandInterpreterDependencyService);
- serviceManager.addSingleton<IJupyterSubCommandExecutionService>(IJupyterSubCommandExecutionService, JupyterCommandFinderInterpreterExecutionService);
- } else {
- serviceManager.addSingleton<IJupyterInterpreterDependencyManager>(IJupyterInterpreterDependencyManager, JupyterInterpreterSubCommandExecutionService);
- serviceManager.addSingleton<IJupyterSubCommandExecutionService>(IJupyterSubCommandExecutionService, JupyterInterpreterSubCommandExecutionService);
- }
+ serviceManager.addSingleton<IJupyterInterpreterDependencyManager>(IJupyterInterpreterDependencyManager, JupyterInterpreterSubCommandExecutionService);
+ serviceManager.addSingleton<IJupyterSubCommandExecutionService>(IJupyterSubCommandExecutionService, JupyterInterpreterSubCommandExecutionService);
 
  registerGatherTypes(serviceManager);
 }

src/client/datascience/jupyter/interpreter/jupyterCommandInterpreterDependencyService.ts

@@ -1516,7 +1516,6 @@ export interface IEventNamePropertyMapping {
  [EventName.WORKSPACE_SYMBOLS_GO_TO]: never | undefined;
  // Data Science
  [Telemetry.AddCellBelow]: never | undefined;
- [Telemetry.ClassConstructionTime]: { class: string };
  [Telemetry.CodeLensAverageAcquisitionTime]: never | undefined;
  [Telemetry.CollapseAll]: never | undefined;
  [Telemetry.ConnectFailedJupyter]: never | undefined;