Skip to content

Commit 4d28401

Browse files
authored
Merge pull request #813 from rwightman/opt_cleanup
Optimizer cleanup and additions
2 parents 368211d + a6af48b commit 4d28401

File tree

18 files changed

+1156
-470
lines changed

18 files changed

+1156
-470
lines changed

.github/workflows/tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ jobs:
1717
matrix:
1818
os: [ubuntu-latest, macOS-latest]
1919
python: ['3.8']
20-
torch: ['1.8.1']
21-
torchvision: ['0.9.1']
20+
torch: ['1.9.0']
21+
torchvision: ['0.10.0']
2222
runs-on: ${{ matrix.os }}
2323

2424
steps:
@@ -43,7 +43,7 @@ jobs:
4343
- name: Install requirements
4444
run: |
4545
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
46-
pip install --no-cache-dir git+https://github.com/mapillary/inplace_abn.git@v1.0.12
46+
pip install --no-cache-dir git+https://github.com/mapillary/inplace_abn.git@v1.1.0
4747
- name: Run tests
4848
env:
4949
LD_PRELOAD: /usr/lib/x86_64-linux-gnu/libtcmalloc.so.4

benchmark.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,8 @@ def __init__(self, model_name, device='cuda', torchscript=False, **kwargs):
255255

256256
self.optimizer = create_optimizer_v2(
257257
self.model,
258-
optimizer_name=kwargs.pop('opt', 'sgd'),
259-
learning_rate=kwargs.pop('lr', 1e-4))
258+
opt=kwargs.pop('opt', 'sgd'),
259+
lr=kwargs.pop('lr', 1e-4))
260260

261261
def _gen_target(self, batch_size):
262262
return torch.empty(

0 commit comments

Comments
 (0)