Enforce sprintf for exceptions

Author: dantleech

src/Symfony/Bundle/FrameworkBundle/Command/ConfigDumpReferenceCommand.php

@@ -84,7 +84,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
  }
 
  if (!$extension) {
- throw new \LogicException('No extensions with configuration available for "'.$name.'"');
+ throw new \LogicException(sprintf('No extensions with configuration available for "%s"', $name));
  }
 
  $message = 'Default configuration for "'.$name.'"';
@@ -100,7 +100,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
  }
 
  if (!$extension) {
- throw new \LogicException('No extension with alias "'.$name.'" is enabled');
+ throw new \LogicException(sprintf('No extension with alias "%s" is enabled', $name));
  }
 
  $message = 'Default configuration for extension with alias: "'.$name.'"';
@@ -109,14 +109,11 @@ protected function execute(InputInterface $input, OutputInterface $output)
  $configuration = $extension->getConfiguration(array(), $containerBuilder);
 
  if (!$configuration) {
- throw new \LogicException('The extension with alias "'.$extension->getAlias().
- '" does not have it\'s getConfiguration() method setup');
+ throw new \LogicException(sprintf('The extension with alias "%s" does not have it\'s getConfiguration() method setup', $extension->getAlias()));
  }
 
  if (!$configuration instanceof ConfigurationInterface) {
- throw new \LogicException(
- 'Configuration class "'.get_class($configuration).
- '" should implement ConfigurationInterface in order to be dumpable');
+ throw new \LogicException(sprintf('Configuration class "%s" should implement ConfigurationInterface in order to be dumpable', get_class($configuration)));
  }
 
  $output->writeln($message);

src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/TwigExtensionTest.php

@@ -184,7 +184,7 @@ private function loadFromFile(ContainerBuilder $container, $file, $format)
  $loader = new YamlFileLoader($container, $locator);
  break;
  default:
- throw new \InvalidArgumentException('Unsupported format: '.$format);
+ throw new \InvalidArgumentException(sprintf('Unsupported format: %s', $format));
  }
 
  $loader->load($file.'.'.$format);

src/Symfony/Component/BrowserKit/Client.php

@@ -293,7 +293,7 @@ protected function doRequestInProcess($request)
  $process->run();
 
  if (!$process->isSuccessful() || !preg_match('/^O\:\d+\:/', $process->getOutput())) {
- throw new \RuntimeException('OUTPUT: '.$process->getOutput().' ERROR OUTPUT: '.$process->getErrorOutput());
+ throw new \RuntimeException(sprintf('OUTPUT: %s ERROR OUTPUT: %s', $process->getOutput(), $process->getErrorOutput()));
  }
 
  return unserialize($process->getOutput());

src/Symfony/Component/Console/Formatter/OutputFormatter.php

@@ -130,7 +130,7 @@ public function hasStyle($name)
  public function getStyle($name)
  {
  if (!$this->hasStyle($name)) {
- throw new \InvalidArgumentException('Undefined style: '.$name);
+ throw new \InvalidArgumentException(sprintf('Undefined style: %s', $name));
  }
 
  return $this->styles[strtolower($name)];

src/Symfony/Component/CssSelector/Parser/Handler/StringHandler.php

@@ -64,7 +64,7 @@ public function handle(Reader $reader, TokenStream $stream)
  $match = $reader->findPattern($this->patterns->getQuotedStringPattern($quote));
 
  if (!$match) {
- throw new InternalErrorException('Should have found at least an empty match at '.$reader->getPosition().'.');
+ throw new InternalErrorException(sprintf('Should have found at least an empty match at %s.', $reader->getPosition()));
  }
 
  // check unclosed strings

src/Symfony/Component/CssSelector/XPath/Extension/FunctionExtension.php

@@ -58,7 +58,7 @@ public function translateNthChild(XPathExpr $xpath, FunctionNode $function, $las
  try {
  list($a, $b) = Parser::parseSeries($function->getArguments());
  } catch (SyntaxErrorException $e) {
- throw new ExpressionErrorException('Invalid series: '.implode(', ', $function->getArguments()), 0, $e);
+ throw new ExpressionErrorException(sprintf('Invalid series: %s', implode(', ', $function->getArguments())), 0, $e);
  }
 
  $xpath->addStarPrefix();

src/Symfony/Component/CssSelector/XPath/Translator.php

@@ -175,7 +175,7 @@ public function registerExtension(Extension\ExtensionInterface $extension)
  public function getExtension($name)
  {
  if (!isset($this->extensions[$name])) {
- throw new ExpressionErrorException('Extension "'.$name.'" not registered.');
+ throw new ExpressionErrorException(sprintf('Extension "%s" not registered.', $name));
  }
 
  return $this->extensions[$name];
@@ -205,7 +205,7 @@ public function registerParserShortcut(ParserInterface $shortcut)
  public function nodeToXPath(NodeInterface $node)
  {
  if (!isset($this->nodeTranslators[$node->getNodeName()])) {
- throw new ExpressionErrorException('Node "'.$node->getNodeName().'" not supported.');
+ throw new ExpressionErrorException(sprintf('Node "%s" not supported.', $node->getNodeName()));
  }
 
  return call_user_func($this->nodeTranslators[$node->getNodeName()], $node);
@@ -223,7 +223,7 @@ public function nodeToXPath(NodeInterface $node)
  public function addCombination($combiner, NodeInterface $xpath, NodeInterface $combinedXpath)
  {
  if (!isset($this->combinationTranslators[$combiner])) {
- throw new ExpressionErrorException('Combiner "'.$combiner.'" not supported.');
+ throw new ExpressionErrorException(sprintf('Combiner "%s" not supported.', $combiner));
  }
 
  return call_user_func($this->combinationTranslators[$combiner], $this->nodeToXPath($xpath), $this->nodeToXPath($combinedXpath));
@@ -240,7 +240,7 @@ public function addCombination($combiner, NodeInterface $xpath, NodeInterface $c
  public function addFunction(XPathExpr $xpath, FunctionNode $function)
  {
  if (!isset($this->functionTranslators[$function->getName()])) {
- throw new ExpressionErrorException('Function "'.$function->getName().'" not supported.');
+ throw new ExpressionErrorException(sprintf('Function "%s" not supported.', $function->getName()));
  }
 
  return call_user_func($this->functionTranslators[$function->getName()], $xpath, $function);
@@ -257,7 +257,7 @@ public function addFunction(XPathExpr $xpath, FunctionNode $function)
  public function addPseudoClass(XPathExpr $xpath, $pseudoClass)
  {
  if (!isset($this->pseudoClassTranslators[$pseudoClass])) {
- throw new ExpressionErrorException('Pseudo-class "'.$pseudoClass.'" not supported.');
+ throw new ExpressionErrorException(sprintf('Pseudo-class "%s" not supported.', $pseudoClass));
  }
 
  return call_user_func($this->pseudoClassTranslators[$pseudoClass], $xpath);
@@ -276,7 +276,7 @@ public function addPseudoClass(XPathExpr $xpath, $pseudoClass)
  public function addAttributeMatching(XPathExpr $xpath, $operator, $attribute, $value)
  {
  if (!isset($this->attributeMatchingTranslators[$operator])) {
- throw new ExpressionErrorException('Attribute matcher operator "'.$operator.'" not supported.');
+ throw new ExpressionErrorException(sprintf('Attribute matcher operator "%s" not supported.', $operator));
  }
 
  return call_user_func($this->attributeMatchingTranslators[$operator], $xpath, $attribute, $value);

src/Symfony/Component/DependencyInjection/ContainerBuilder.php

@@ -640,7 +640,7 @@ public function setAlias($alias, $id)
  }
 
  if ($alias === strtolower($id)) {
- throw new InvalidArgumentException('An alias can not reference itself, got a circular reference on "'.$alias.'".');
+ throw new InvalidArgumentException(sprintf('An alias can not reference itself, got a circular reference on "%s".', $alias));
  }
 
  unset($this->definitions[$alias]);

src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php

@@ -660,7 +660,7 @@ private function addNewInstance($id, Definition $definition, $return, $instantia
  return sprintf(" $return{$instantiation}%s->%s(%s);\n", $this->getServiceCall($definition->getFactoryService()), $definition->getFactoryMethod(), implode(', ', $arguments));
  }
 
- throw new RuntimeException('Factory method requires a factory service or factory class in service definition for '.$id);
+ throw new RuntimeException(sprintf('Factory method requires a factory service or factory class in service definition for %s', $id));
  }
 
  if (false !== strpos($class, '$')) {

src/Symfony/Component/Finder/Adapter/BsdFindAdapter.php

@@ -62,7 +62,7 @@ protected function buildFormatSorting(Command $command, $sort)
  $format = '%m';
  break;
  default:
- throw new \InvalidArgumentException('Unknown sort options: '.$sort.'.');
+ throw new \InvalidArgumentException(sprintf('Unknown sort options: %s.', $sort));
  }
 
  $command