Skip to content

Add log message about Vert.x at start up #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2022
Merged

Add log message about Vert.x at start up #1142

merged 2 commits into from
Jan 19, 2022

Conversation

@DavideD
Copy link
Member

@DavideD DavideD commented Jan 19, 2022

Fixes #1134

  • If not detected:
    [INFO] HR000002: Vert.x not detected, creating a new instance
  • if detected:
    [DEBUG] Vert.x instance detected
@DavideD
Format DefaultVertxInstance
8bcaac8
@DavideD
[hibernate#1134] Add log message for Vert.x at startup
cb52889 
If not detected: ``` [INFO] HR000002: Vert.x not detected, creating a new instance ``` if detected: ``` [DEBUG] Vert.x instance detected ```
@DavideD DavideD added this to the next milestone Jan 19, 2022
@DavideD DavideD requested a review from gavinking January 19, 2022 11:32
@DavideD DavideD changed the title Log message about Vert.x at start up Add log message about Vert.x at start up Jan 19, 2022
@gavinking
Copy link
Member

gavinking commented Jan 19, 2022

Should we have codes for the debug messages?
@DavideD
Copy link
Member Author

DavideD commented Jan 19, 2022 •
edited
Loading

As far as I know, anything from debug and under doesn't need to have a code.
That said, I'm not against it in principle but this debug message doesn't seem super helpful and most people won't see it.
Not sure if a code in this case would be helpful
@DavideD
Copy link
Member Author

DavideD commented Jan 19, 2022

I'm happy to move it to INFO level so that we always print something
@gavinking
Copy link
Member

gavinking commented Jan 19, 2022

No no, just wanted to make sure we were being consistent. Don't recall what we do with other debug-level log messages.
@DavideD DavideD merged commit 9cc0bb3 into hibernate:main Jan 19, 2022
@DavideD
Copy link
Member Author

DavideD commented Jan 19, 2022

Merged #1142
@DavideD DavideD deleted the 1134-log-message branch January 19, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@DavideD @gavinking