merged branch eventhorizonpl/100ptc_component_httpfundation_p3 (PR symfony#5414)

Commits ------- c74d9a9 ResponseHeaderBag tests Discussion ---------- ResponseHeaderBag tests Hi, This patch adds some ResponseHeaderBag tests. Now ResponseHeaderBag got 100% test coverage :) Best regards, Michal

Author: fabpot

src/Symfony/Component/HttpFoundation/Tests/ResponseHeaderBagTest.php

@@ -76,6 +76,29 @@ public function testToStringIncludesCookieHeaders()
  $this->assertContains("Set-Cookie: foo=deleted; expires=".gmdate("D, d-M-Y H:i:s T", time() - 31536001)."; httponly", explode("\r\n", $bag->__toString()));
  }
 
+ public function testReplace()
+ {
+ $bag = new ResponseHeaderBag(array());
+ $this->assertEquals('no-cache', $bag->get('Cache-Control'));
+ $this->assertTrue($bag->hasCacheControlDirective('no-cache'));
+
+ $bag->replace(array('Cache-Control' => 'public'));
+ $this->assertEquals('public', $bag->get('Cache-Control'));
+ $this->assertTrue($bag->hasCacheControlDirective('public'));
+ }
+
+ public function testReplaceWithRemove()
+ {
+ $bag = new ResponseHeaderBag(array());
+ $this->assertEquals('no-cache', $bag->get('Cache-Control'));
+ $this->assertTrue($bag->hasCacheControlDirective('no-cache'));
+
+ $bag->remove('Cache-Control');
+ $bag->replace(array());
+ $this->assertEquals('no-cache', $bag->get('Cache-Control'));
+ $this->assertTrue($bag->hasCacheControlDirective('no-cache'));
+ }
+
  public function testCookiesWithSameNames()
  {
  $bag = new ResponseHeaderBag();
@@ -119,6 +142,34 @@ public function testRemoveCookie()
  $this->assertFalse(isset($cookies['foo.bar']));
  }
 
+ public function testRemoveCookieWithNullRemove()
+ {
+ $bag = new ResponseHeaderBag();
+ $bag->setCookie(new Cookie('foo', 'bar', 0));
+ $bag->setCookie(new Cookie('bar', 'foo', 0));
+
+ $cookies = $bag->getCookies(ResponseHeaderBag::COOKIES_ARRAY);
+ $this->assertTrue(isset($cookies['']['/']));
+
+ $bag->removeCookie('foo', null);
+ $cookies = $bag->getCookies(ResponseHeaderBag::COOKIES_ARRAY);
+ $this->assertFalse(isset($cookies['']['/']['foo']));
+
+ $bag->removeCookie('bar', null);
+ $cookies = $bag->getCookies(ResponseHeaderBag::COOKIES_ARRAY);
+ $this->assertFalse(isset($cookies['']['/']['bar']));
+ }
+
+ /**
+ * @expectedException \InvalidArgumentException
+ */
+ public function testGetCookiesWithInvalidArgument()
+ {
+ $bag = new ResponseHeaderBag();
+
+ $cookies = $bag->getCookies('invalid_argument');
+ }
+
  /**
  * @expectedException \InvalidArgumentException
  */