feat!: Default to github cache, blacksmith or no cache are configurable, extensive 1.7.10 logging #74

3arthqu4ke · 2025-05-14T02:33:32Z

Related: #23

Copilot

Pull Request Overview

This PR improves logging for Minecraft 1.7.10 by adding a new NetworkManager mixin and adjusts the default caching behavior along with corresponding documentation and workflow updates.

Change cache-mc default from true to false in the GitHub Action
Add a Caching section to the README for enabling .minecraft caching
Introduce MixinNetworkManager to log outbound/inbound packets and exceptions
Update workflows to respect the new cache-mc input

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
action.yml	Changed `cache-mc` default to `false`
README.md	Added "## Caching" section explaining `cache-mc` usage
1_7_10/src/main/resources/mc_runtime_test.mixins.json	Registered new `MixinNetworkManager` in the mixin config
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java	Added logging hooks for packet send/receive and exceptions
.github/workflows/test-local-action.yml	Removed hardcoded `cache-mc` override
.github/workflows/run-gametests.yml	Enabled `cache-mc: "true"` for game test runs
.github/workflows/lifecycle.yml	Enabled `cache-mc: "true"` in lifecycle workflow

README.md

1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java

…rkManager.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

This PR refines caching behavior by changing the default for cache-mc, adds a new mixin to improve packet logging in MC 1.7.10, and updates docs and workflows to reflect these changes.

Default cache-mc input flipped to false; workflows updated to opt in/out.
New MixinNetworkManager mixin logs outbound, inbound, and exception events.
README gains a “Caching” section with setup instructions.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
action.yml	Changed default `cache-mc` from `"true"` to `"false"`
README.md	Added “Caching” section with Blacksmith instructions
1_7_10/src/main/resources/mc_runtime_test.mixins.json	Registered new `MixinNetworkManager` mixin
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java	Implemented packet and error logging injections
.github/workflows/test-local-action.yml	Removed hardcoded `cache-mc` override
.github/workflows/run-gametests.yml	Enabled caching via `cache-mc: "true"`
.github/workflows/lifecycle.yml	Enabled caching via `cache-mc: "true"`

README.md

1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java

Copilot

Pull Request Overview

This PR updates caching defaults and enhances logging for Minecraft 1.7.10 network packets.

Changed cache-mc default to false and re-enabled it in CI workflows where needed
Added a new MixinNetworkManager mixin and corresponding JSON entry to log outbound/inbound packets and exceptions
Extended README with a new Caching section describing how to enable .minecraft caching

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
action.yml	Changed default of `cache-mc` from `"true"` to `"false"`
README.md	Added a Caching section explaining how to enable the `cache-mc` input
1_7_10/src/main/resources/mc_runtime_test.mixins.json	Added `"MixinNetworkManager"` to mixin list
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java	Introduced packet logging and exception hooks via mixins
.github/workflows/test-local-action.yml	Removed hardcoded `cache-mc: false` to rely on new default
.github/workflows/run-gametests.yml	Explicitly set `cache-mc: "true"` for game-test runs
.github/workflows/lifecycle.yml	Enabled `cache-mc: "true"` in lifecycle jobs

Comments suppressed due to low confidence (1)

1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java:22

[nitpick] This new logging hook isn’t covered by existing tests; consider adding an integration or unit test to verify that packet logging behaves as expected.

@Inject(method = "scheduleOutboundPacket", at = @At("HEAD"))

README.md

1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java

3arthqu4ke · 2025-06-01T02:15:47Z

@ChipWolf defaults to github cache now, but blacksmith is configurable.

okafke

LGTM!

* chore(mod): 1.21.5 (headlesshq#64) * chore(deps): update googleapis/release-please-action digest to a02a34c (headlesshq#62) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(deps): support 1.21.5 and update to HeadlessMc 2.5.1 * chore(main): release 3.1.0 (headlesshq#68) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore(docs): escape characters in README (headlesshq#69) * fix(action): Change cache keys to prevent prefix fallback to cache of incorrect version (headlesshq#71) * chore(main): release 3.1.1 (headlesshq#72) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore(deps): update useblacksmith/setup-gradle digest to 7f7b355 (headlesshq#75) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/download-artifact digest to d3f86a1 (headlesshq#65) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update useblacksmith/setup-java digest to 4ef8123 (headlesshq#63) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/upload-artifact digest to ea165f8 (headlesshq#55) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency net.fabricmc.fabric-api:fabric-gametest-api-v1 to v1.3.16+1172e8970d (headlesshq#76) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat!: Default to github cache, blacksmith or no cache are configurable, extensive 1.7.10 logging (headlesshq#74) Co-authored-by: Chip Wolf ‮ <hello@chipwolf.uk> Co-authored-by: Chip Wolf ‮ <chipukyt@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore(main): release 4.0.0 (headlesshq#78) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore(ci): automatic PR when new Mc version is available (headlesshq#85) * chore(ci): add requirements.txt * chore(ci): fix new mc version workflow (headlesshq#88) * chore(ci): fix reviewers and syntax in new mc version workflow (headlesshq#90) * chore(ci): run matrix based on PR message (headlesshq#92) * chore(ci): use find-comment action to find PR comment (headlesshq#94) * chore(ci): use pull_request.body * chore(ci): log PR comment body matching * chore(ci): Fixed regex for PR comment body matching * chore(ci): Fixed regex for PR comments not matching zeros * chore(ci): modify README in new mc version workflow (headlesshq#103) * feat(mod): Support 1.21.6 (headlesshq#81) Co-authored-by: okafke <65917827+okafke@users.noreply.github.com> * fix(action): switch from wget to curl to support windows (headlesshq#104) * chore(main): release 4.1.0 (headlesshq#106) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore(docs): add supported versions to README * chore(ci): read build & run data from file (headlesshq#111) * chore(ci): improve README modification * chore(deps): update dependency urllib3 to v2.6.0 [security] (headlesshq#113) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * refactor: 1.21.10 already handled by 1_21_9 * ci: null2264 * ci: Use github cache * ci: Use github cache * refactor: Switching to uv --------- Co-authored-by: 3arthqu4ke <56741599+3arthqu4ke@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Chip Wolf ‮ <hello@chipwolf.uk> Co-authored-by: Chip Wolf ‮ <chipukyt@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: okafke <65917827+okafke@users.noreply.github.com>

fix(mod): Better logging for 1.7.10

337f120

3arthqu4ke linked an issue May 14, 2025 that may be closed by this pull request

Investigate caches #73

Closed

3arthqu4ke marked this pull request as draft May 14, 2025 02:33

chore(docs): Document use of blacksmith for caching

5a761fe

3arthqu4ke changed the title ~~fix(mod): Fix caches and better logging for 1.7.10~~ fix(mod): Better logging for 1.7.10 May 14, 2025

chore: disable cache by default

dc1c3e2

ChipWolf changed the title ~~fix(mod): Better logging for 1.7.10~~ fix(mod): better logging for 1.7.10 May 31, 2025

ChipWolf changed the title ~~fix(mod): better logging for 1.7.10~~ fix(mod): better logging for 1.7.10, change caching default May 31, 2025

ChipWolf requested a review from Copilot May 31, 2025 20:04

ChipWolf assigned 3arthqu4ke May 31, 2025

ChipWolf mentioned this pull request May 31, 2025

Investigate caches #73

Closed

Copilot AI reviewed May 31, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java Outdated Show resolved Hide resolved

1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java Outdated Show resolved Hide resolved

Update 1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetwo…

fbd814d

…rkManager.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ChipWolf requested a review from Copilot May 31, 2025 20:09

chore(docs): capitalisation nitpick

4624f28

Copilot AI reviewed May 31, 2025

View reviewed changes

ChipWolf requested a review from Copilot May 31, 2025 20:17

Copilot AI reviewed May 31, 2025

View reviewed changes

README.md Show resolved Hide resolved

1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java Show resolved Hide resolved

1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java Show resolved Hide resolved

chore(docs): Make cache step configurable, default to github cache

8e2ccc9

3arthqu4ke marked this pull request as ready for review June 1, 2025 02:15

3arthqu4ke changed the title ~~fix(mod): better logging for 1.7.10, change caching default~~ feature(mod): better logging for 1.7.10, default to github caching Jun 1, 2025

3arthqu4ke changed the title ~~feature(mod): better logging for 1.7.10, default to github caching~~ fix(mod): better logging for 1.7.10, default to github caching Jun 1, 2025

3arthqu4ke requested a review from ChipWolf June 4, 2025 04:46

3arthqu4ke changed the title ~~fix(mod): better logging for 1.7.10, default to github caching~~ feat(ci)!: Default to github cache, blacksmith or no cache are configurable, extensive 1.7.10 logging Jun 26, 2025

3arthqu4ke changed the title ~~feat(ci)!: Default to github cache, blacksmith or no cache are configurable, extensive 1.7.10 logging~~ feat!: Default to github cache, blacksmith or no cache are configurable, extensive 1.7.10 logging Jun 26, 2025

okafke approved these changes Nov 10, 2025

View reviewed changes

okafke merged commit 0031914 into main Nov 10, 2025
8 checks passed

okafke deleted the 73-investigate-caches branch November 10, 2025 12:57

github-actions bot mentioned this pull request Nov 10, 2025

chore(main): release 4.0.0 #78

Merged

okafke mentioned this pull request Nov 14, 2025

Fix 1.7.10 and 1.19-1.19.3 flakyness #23

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat!: Default to github cache, blacksmith or no cache are configurable, extensive 1.7.10 logging #74

feat!: Default to github cache, blacksmith or no cache are configurable, extensive 1.7.10 logging #74

Uh oh!

3arthqu4ke commented May 14, 2025 •

edited

Loading

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

3arthqu4ke commented Jun 1, 2025

okafke left a comment

Uh oh!

Labels

4 participants

feat!: Default to github cache, blacksmith or no cache are configurable, extensive 1.7.10 logging #74

feat!: Default to github cache, blacksmith or no cache are configurable, extensive 1.7.10 logging #74

Uh oh!

Conversation

3arthqu4ke commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

3arthqu4ke commented Jun 1, 2025

okafke left a comment

Choose a reason for hiding this comment

Uh oh!

Labels

4 participants

3arthqu4ke commented May 14, 2025 •

edited

Loading