Vanilla: remove invalid check of responseType #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ghost mentioned this pull request 
Contributor Author
| @phadej Is there anything holding this back? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi @phadej,
I am sorry, but my original PR #9 didn't fix the issue with vanilla js but made the situation worse. At least it doesn't work for me anymore.
According to the XmlHttpRequest docs one has to set responseType before the request! Then one can just use xhr.response which will be either null or a valid object. See https://github.com/minad/servant-js/commit/a9922ac83cfcee83aabf06599264b7b3c693523b for a version which uses responseType correctly. Unfortunately this doesn't seem to be widely supported yet.
It worked before since I had onSuccess at the wrong place, which you pointed out. But then I probably didn't test the corrected version. Now onError is called always since responseType never equals json.
I recommend to merge this fix which removes the invalid check.
Daniel