Skip to content

Added ListResource RPC #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 18, 2025
Merged

Added ListResource RPC #313

merged 8 commits into from
Jun 18, 2025

Conversation

@rainkwan
Copy link
Contributor

@rainkwan rainkwan commented Jun 16, 2025 •
edited
Loading

Related Issue

Continue from #312

Description

Adds ListResource RPC for Search

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

No
@rainkwan rainkwan marked this pull request as ready for review June 16, 2025 20:52
@rainkwan rainkwan requested a review from a team as a code owner June 16, 2025 20:52
@rainkwan rainkwan marked this pull request as draft June 16, 2025 20:53
@rainkwan rainkwan force-pushed the rk/validatelist-rpc branch from 388806f to eab58a0 Compare June 16, 2025 20:53
bbasata
bbasata reviewed Jun 16, 2025
View reviewed changes
bbasata
bbasata reviewed Jun 16, 2025
View reviewed changes
@rainkwan rainkwan changed the title Started adding ListResourceRPC Added ListResourceRPC Jun 16, 2025
@rainkwan rainkwan added this to the v0.21.0 milestone Jun 16, 2025
@rainkwan rainkwan changed the title Added ListResourceRPC Added ListResource RPC Jun 16, 2025
bbasata
bbasata previously approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@bbasata bbasata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent to me. All the review comments are non-blocking. :shipit:
tf5muxserver/mux_server_ListResource.go
Severity: tfprotov5.DiagnosticSeverityError,
Summary: "ListResource Not Implemented",
Detail: "A ListResource call was received by the provider, however the provider does not implement ListResource. " +
"Either upgrade the provider to a version that implements ListResource or this is a bug in Terraform that should be reported to the Terraform maintainers.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 Not specific to this pull request: I wonder how this could be a bug in Terraform.
@rainkwan rainkwan marked this pull request as ready for review June 17, 2025 14:57
bbasata
bbasata reviewed Jun 17, 2025
View reviewed changes
bbasata
bbasata reviewed Jun 17, 2025
View reviewed changes
bbasata
bbasata approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@bbasata bbasata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@rainkwan rainkwan merged commit 9447a02 into main Jun 18, 2025
35 checks passed
@rainkwan rainkwan deleted the rk/validatelist-rpc branch June 18, 2025 14:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@rainkwan @bbasata @SBGoods