Allow passing a ready Redis client #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
An example use-case being passing a Redis client that's able to fail over, but transparently implements the usual `redis` module API. This approach has one problem: `Connection#stop` still closes the passed connection, while in the case of a passed connection this should be up to the callee, but since `stop` isn't widely used except when closing down the process, I don't believe this will cause any problems.
LoicMahieu force-pushed the pass-own-client branch from 51ddba2 to bc3751b Compare LoicMahieu added a commit that referenced this pull request Mar 15, 2016
Allow passing a ready Redis client
| This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Rebase of #29