Error handling optimiyed

Author: hANSIc99

TODOS

@@ -10,7 +10,27 @@ Documentation:
  When an element returns None, subsequent
  elements are still triggered
 
- Exceptions:
+ Logging:
+
+ #1 INFO:
+ Ordinary debug trace messages
+ Can be switched on or off by the user (checkbox in element configuration)
+ Implementation in own code is optional
+ 
+
+ #2 WARNING: 
+ Signalize a failed execution
+ Can be switched on or off by the user (checkbox in element configuration)
+ A log entry of this type is created when the element returns data of type PythonicError
+ Implementation in own code is optional
+
+ #3 Critical (Unhandled exception):
+ Is signalized in the GUI an (,,Exception occured, open log for details)
+ Log entry (type ERROR) is made
+ Is always active (implementation not optional)
+
+
+ Error handling:
 
  #1
  Elements should throw an exception when configuration
@@ -21,16 +41,19 @@ Documentation:
  and only throw critical exceptions.
 
  #3
- If appropriate, the result of a operation (if successfull or not) should
- be forwarded to subsequent elements in order to react to
- a possible unsuccesfull operation. When it was not possible to process the input data, return the PythonicError with related information.
- Combine this with logging.warning (preferred) or logging.error.
+ The result of a operation (if successfull or not (see #2)) should always
+ be forwarded to subsequent elements in order to react to a possible failed call.
+ If the result of a failed call could be processed by an subsequent element,
+ it should be wrapped inside the PythonicError type.
 
  #4
- Avoid to use logging.error or logging.warning without the other mechanisms as those methods will only write to the log.
+ In case of a failed call, a meaningful message or the exception text should returned
+ (PythonicError as data parameter in returned Record type)
 
+ #4
+ Dont to use logging.error or logging.warning as it has no effect if used in combination with multiprocessing.
 
-Check exception rules
+1917141915:AAHRe-CZhv8fIv6bQzHMipgYPuVnQbQGxtY
 
 CCXT Method: Try to optimize large if-else areas for parsing config
 

src/Pythonic/executables/email.py

@@ -52,10 +52,8 @@ def execute(self):
 
  if not sender:
  raise Exception('Sender missing in configuration')
-
  if not password:
  raise Exception('Password missing in configuration')
-
  if not url:
  raise Exception('URL missing in configuration')
  if not port:
@@ -64,15 +62,15 @@ def execute(self):
 
  if isinstance(self.inputData, dict):
  if not 'recipient' in self.inputData or not isinstance(self.inputData['recipient'], str):
- recordDone = Record(None, message='Key "recipient" not found or not of type string')
+ recordDone = Record(PythonicError('Key error, see log for details'), message='Key "recipient" not found or not of type string')
  self.return_queue.put(recordDone)
  return
  if not 'subject' in self.inputData or not isinstance(self.inputData['subject'], str):
- recordDone = Record(None, message='Key "subject" not found or not of type string')
+ recordDone = Record(PythonicError('Key error, see log for details'), message='Key "subject" not found or not of type string')
  self.return_queue.put(recordDone)
  return
  if not 'message' in self.inputData or not isinstance(self.inputData['message'], str):
- recordDone = Record(None, message='Key "subject" not found or not of type string')
+ recordDone = Record(PythonicError('Key error, see log for details'), message='Key "subject" not found or not of type string')
  self.return_queue.put(recordDone)
  return
 
@@ -85,14 +83,11 @@ def execute(self):
 
  attachments = self.inputData['attachment']
 
-
  else:
- recordDone = Record(None, message='Config missing')
+ recordDone = Record(PythonicError('Config missing'), message='Config missing')
  self.return_queue.put(recordDone)
  return
 
-
- 
  msg = EmailMessage()
  msg['Subject'] = subject
  msg['From'] = sender

src/Pythonic/executables/sqlite.py

@@ -1,4 +1,4 @@
-import time, queue, sqlite3, logging
+import time, queue, sqlite3
 try:
  from element_types import Record, Function, ProcCMD, GuiCMD, PythonicError
 except ImportError: 
@@ -48,7 +48,6 @@ def execute(self):
  try:
  cur.execute(self.inputData)
  except Exception as e:
- logging.warning(e)
  recordDone = Record(PythonicError(e), 'Query failed') 
  self.return_queue.put(recordDone)
  con.close() 

src/Pythonic/executables/telegram.py

@@ -1,16 +1,12 @@
-import logging, queue
+import queue
 from telegram import Update
 from telegram.ext import Updater, CommandHandler, CallbackContext, MessageHandler, Filters
 
 try:
- from element_types import Record, Function, ProcCMD, GuiCMD, SetPersist
+ from element_types import Record, Function, ProcCMD, GuiCMD, SetPersist, PythonicError
 except ImportError: 
- from Pythonic.element_types import Record, Function, ProcCMD, GuiCMD, SetPersist
+ from Pythonic.element_types import Record, Function, ProcCMD, GuiCMD, SetPersist, PythonicError
 
-try:
- from element_types import Record, Function, ProcCMD, GuiCMD
-except ImportError: 
- from Pythonic.element_types import Record, Function, ProcCMD, GuiCMD
 
 class Element(Function):
 
@@ -89,15 +85,11 @@ def message(update, context):
  guitext = GuiCMD("Sending data: " + str(cmd.data))
  self.return_queue.put(guitext)
 
- for chat_id in chat_ids:
+ for chat_id in chat_ids.copy():
  try:
  dispatcher.bot.send_message(chat_id=chat_id, text=str(cmd.data))
  except Exception as e:
- # BAUSTELLE # Return Error Element ?
- logging.error(e)
  chat_ids.discard(chat_id)
- logging.warning('ChatId removed')
- 
-
+ self.return_queue.put(Record(PythonicError(e), 'Error sending message, related chat id removed'))
 
  cmd = None

src/Pythonic/execution_operator.py

@@ -10,9 +10,9 @@
 
 
 try:
- from element_types import Record, ProcCMD, GuiCMD, GuiException
+ from element_types import Record, ProcCMD, GuiCMD, GuiException, PythonicError
 except ImportError: 
- from Pythonic.element_types import Record, ProcCMD, GuiCMD, GuiException
+ from Pythonic.element_types import Record, ProcCMD, GuiCMD, GuiException, PythonicError
 
 
 
@@ -177,7 +177,7 @@ def run(self):
 
 class OperatorElementOpDone(QRunnable):
 
- def __init__(self, config, id, record, identifier, operator):
+ def __init__(self, config, id, record : Record, identifier, operator):
  super(OperatorElementOpDone, self).__init__()
 
 
@@ -194,8 +194,13 @@ def run(self):
 
  cfgElement = [x for x in self.currentConfig if x['Id'] == self.id][0]
 
+
+
  if cfgElement['Config']['GeneralConfig']['Logging'] and self.record.message: # Log Message enabled
- logging.info('{} - {}'.format(cfgElement['ObjectName'], self.record.message))
+ if isinstance(self.record.data, PythonicError):
+ logging.warning('{} - {}'.format(cfgElement['ObjectName'], self.record.message))
+ else:
+ logging.info('{} - {}'.format(cfgElement['ObjectName'], self.record.message))
 
  data = {
  'Id' : cfgElement['Id'],