Don't use npx for webpack build and update npm version (microsoft#9387)

Author: IanMatthewHuff

build/ci/templates/globals.yml

@@ -1,7 +1,7 @@
 variables:
  PythonVersion: '3.7' # Always use latest version.
  NodeVersion: '10.11.0' # Check version of node used in VS Code.
- NpmVersion: '6.10.3'
+ NpmVersion: '6.13.4'
  MOCHA_FILE: '$(Build.ArtifactStagingDirectory)/test-junit.xml' # All test files will write their JUnit xml output to this file, clobbering the last time it was written.
  MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter).
  VSC_PYTHON_FORCE_LOGGING: true # Enable this to turn on console output for the logger

build/ci/templates/steps/initialization.yml

@@ -101,11 +101,10 @@ steps:
  displayName: "Setup NODE_PATH for extension (Debugger Tests)"
  condition: and(succeeded(), eq(variables['agent.os'], 'Darwin'))
 
- # We need these almost always.
+ # Install vsce 
  - bash: |
  npm install -g vsce
- npm install -g npx
- displayName: "Install vsce & npx"
+ displayName: "Install vsce"
  condition: and(succeeded(), eq('${{ parameters.installVSCEorNPX }}', 'true'))
 
  - bash: npx tsc -p ./

gulpfile.js

@@ -111,30 +111,30 @@ gulp.task('checkNativeDependencies', done => {
 gulp.task('check-datascience-dependencies', () => checkDatascienceDependencies());
 
 gulp.task('compile-webviews', async () => {
- await spawnAsync('npx', ['-n', '--max_old_space_size=9096', 'webpack', '--config', './build/webpack/webpack.config.js', '--mode', 'production'], {'BUNDLE_INDEX': '0'});
- await spawnAsync('npx', ['-n', '--max_old_space_size=9096', 'webpack', '--config', './build/webpack/webpack.config.js', '--mode', 'production'], {'BUNDLE_INDEX': '1'});
- await spawnAsync('npx', ['-n', '--max_old_space_size=9096', 'webpack', '--config', './build/webpack/webpack.config.js', '--mode', 'production'], {'BUNDLE_INDEX': '2'});
- await spawnAsync('npx', ['-n', '--max_old_space_size=9096', 'webpack', '--config', './build/webpack/webpack.config.js', '--mode', 'production'], {'BUNDLE_INDEX': '3'});
+ await spawnAsync('npm', ['run', 'webpack', '--', '--config', './build/webpack/webpack.config.js', '--mode', 'production'], { 'NODE_OPTIONS': '--max_old_space_size=9096', 'BUNDLE_INDEX': '0' });
+ await spawnAsync('npm', ['run', 'webpack', '--', '--config', './build/webpack/webpack.config.js', '--mode', 'production'], { 'NODE_OPTIONS': '--max_old_space_size=9096', 'BUNDLE_INDEX': '1' });
+ await spawnAsync('npm', ['run', 'webpack', '--', '--config', './build/webpack/webpack.config.js', '--mode', 'production'], { 'NODE_OPTIONS': '--max_old_space_size=9096', 'BUNDLE_INDEX': '2' });
+ await spawnAsync('npm', ['run', 'webpack', '--', '--config', './build/webpack/webpack.config.js', '--mode', 'production'], { 'NODE_OPTIONS': '--max_old_space_size=9096', 'BUNDLE_INDEX': '3' });
 });
 
 gulp.task('webpack', async () => {
  // Build node_modules and DS stuff.
  // Unwrap the array used to build each webpack.
- await buildWebPack('production', ['--config', './build/webpack/webpack.config.js'], {'BUNDLE_INDEX': '0'});
- await buildWebPack('production', ['--config', './build/webpack/webpack.config.js'], {'BUNDLE_INDEX': '1'});
- await buildWebPack('production', ['--config', './build/webpack/webpack.config.js'], {'BUNDLE_INDEX': '2'});
- await buildWebPack('production', ['--config', './build/webpack/webpack.config.js'], {'BUNDLE_INDEX': '3'});
- await buildWebPack('production', ['--config', './build/webpack/webpack.config.js'], {'BUNDLE_INDEX': '4'});
+ await buildWebPack('production', ['--config', './build/webpack/webpack.config.js'], { 'NODE_OPTIONS': '--max_old_space_size=9096', 'BUNDLE_INDEX': '0' });
+ await buildWebPack('production', ['--config', './build/webpack/webpack.config.js'], { 'NODE_OPTIONS': '--max_old_space_size=9096', 'BUNDLE_INDEX': '1' });
+ await buildWebPack('production', ['--config', './build/webpack/webpack.config.js'], { 'NODE_OPTIONS': '--max_old_space_size=9096', 'BUNDLE_INDEX': '2' });
+ await buildWebPack('production', ['--config', './build/webpack/webpack.config.js'], { 'NODE_OPTIONS': '--max_old_space_size=9096', 'BUNDLE_INDEX': '3' });
+ await buildWebPack('production', ['--config', './build/webpack/webpack.config.js'], { 'NODE_OPTIONS': '--max_old_space_size=9096', 'BUNDLE_INDEX': '4' });
  // Run both in parallel, for faster process on CI.
  // Yes, console would print output from both, that's ok, we have a faster CI.
  // If things fail, we can run locally separately.
  if (isCI) {
- const buildExtension = buildWebPack('extension', ['--config', './build/webpack/webpack.extension.config.js']);
- const buildDebugAdapter = buildWebPack('debugAdapter', ['--config', './build/webpack/webpack.debugadapter.config.js']);
+ const buildExtension = buildWebPack('extension', ['--config', './build/webpack/webpack.extension.config.js'], { 'NODE_OPTIONS': '--max_old_space_size=9096' });
+ const buildDebugAdapter = buildWebPack('debugAdapter', ['--config', './build/webpack/webpack.debugadapter.config.js'], { 'NODE_OPTIONS': '--max_old_space_size=9096' });
  await Promise.all([buildExtension, buildDebugAdapter]);
  } else {
- await buildWebPack('extension', ['--config', './build/webpack/webpack.extension.config.js']);
- await buildWebPack('debugAdapter', ['--config', './build/webpack/webpack.debugadapter.config.js']);
+ await buildWebPack('extension', ['--config', './build/webpack/webpack.extension.config.js'], { 'NODE_OPTIONS': '--max_old_space_size=9096' });
+ await buildWebPack('debugAdapter', ['--config', './build/webpack/webpack.debugadapter.config.js'], { 'NODE_OPTIONS': '--max_old_space_size=9096' });
  }
 });
 
@@ -173,7 +173,7 @@ async function updateBuildNumber(args) {
 async function buildWebPack(webpackConfigName, args, env) {
  // Remember to perform a case insensitive search.
  const allowedWarnings = getAllowedWarningsForWebPack(webpackConfigName).map(item => item.toLowerCase());
- const stdOut = await spawnAsync('npx', ['-n', '--max_old_space_size=9096', 'webpack', ...args, ...['--mode', 'production']], env);
+ const stdOut = await spawnAsync('npm', ['run', 'webpack', '--', ...args, ...['--mode', 'production']], env);
  const stdOutLines = stdOut
  .split(os.EOL)
  .map(item => item.trim())
@@ -335,7 +335,7 @@ gulp.task('uploadReleaseExtension', () => uploadExtension(`ms-python-${process.e
 
 function spawnAsync(command, args, env) {
  env = env || {};
- env = {...process.env, ...env};
+ env = { ...process.env, ...env };
  return new Promise((resolve, reject) => {
  let stdOut = '';
  const proc = spawn(command, args, { cwd: __dirname, env });

news/3 Code Health/7197.md

@@ -0,0 +1 @@
+Remove npx from webpack build as it [breaks on windows](https://github.com/npm/npx/issues/5) on npm 6.11+ and doesn't seem to be getting fixes. Update npm to current version.