Skip to content

Commit 8089c7e

Browse files
pass figure_formats as a set (microsoft#9425)
1 parent d702da8 commit 8089c7e

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

news/2 Fixes/9420.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix the Data Science "Enable Plot Viewer" setting to pass figure_formats correctly when turned off.

src/client/datascience/constants.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -326,10 +326,10 @@ export namespace CodeSnippits {
326326
export const ChangeDirectory = ['{0}', '{1}', 'import os', 'try:', "\tos.chdir(os.path.join(os.getcwd(), '{2}'))", '\tprint(os.getcwd())', 'except:', '\tpass', ''];
327327
export const ChangeDirectoryCommentIdentifier = '# ms-python.python added'; // Not translated so can compare.
328328
export const ImportIPython = '{0}\nfrom IPython import get_ipython\n\n{1}';
329-
export const MatplotLibInitSvg = `import matplotlib\n%matplotlib inline\n${Identifiers.MatplotLibDefaultParams} = dict(matplotlib.rcParams)\n%config InlineBackend.figure_formats = 'svg', 'png'`;
330-
export const MatplotLibInitPng = `import matplotlib\n%matplotlib inline\n${Identifiers.MatplotLibDefaultParams} = dict(matplotlib.rcParams)\n%config InlineBackend.figure_formats = 'png'`;
331-
export const ConfigSvg = `%config InlineBackend.figure_formats = 'svg', 'png'`;
332-
export const ConfigPng = `%config InlineBackend.figure_formats = 'png'`;
329+
export const MatplotLibInitSvg = `import matplotlib\n%matplotlib inline\n${Identifiers.MatplotLibDefaultParams} = dict(matplotlib.rcParams)\n%config InlineBackend.figure_formats = {'svg', 'png'}`;
330+
export const MatplotLibInitPng = `import matplotlib\n%matplotlib inline\n${Identifiers.MatplotLibDefaultParams} = dict(matplotlib.rcParams)\n%config InlineBackend.figure_formats = {'png'}`;
331+
export const ConfigSvg = `%config InlineBackend.figure_formats = {'svg', 'png'}`;
332+
export const ConfigPng = `%config InlineBackend.figure_formats = {'png'}`;
333333
}
334334

335335
export enum JupyterCommands {

0 commit comments

Comments
 (0)