Skip to content

Commit f18ecd2

Browse files
Remove remaining uses of finalize().
1 parent f60e655 commit f18ecd2

File tree

4 files changed

+2
-13
lines changed

4 files changed

+2
-13
lines changed

src/org/freedesktop/gstreamer/glib/GObject.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -603,11 +603,6 @@ void remove() {
603603

604604
abstract protected void disconnect();
605605

606-
// @Override
607-
// protected final void finalize() {
608-
// // Ensure the native callback is removed
609-
// remove();
610-
// }
611606
}
612607

613608
/**

src/org/freedesktop/gstreamer/lowlevel/GValueAPI.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -308,11 +308,6 @@ public Object getValue(int i) {
308308
return v == null ? null : v.getValue();
309309
}
310310

311-
@Override
312-
protected void finalize() throws Throwable {
313-
free();
314-
}
315-
316311
public void free() {
317312
if (ownsMemory) {
318313
GVALUE_API.g_value_array_free(this);

test/org/freedesktop/gstreamer/TestPipe.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,4 @@ public void dispose() {
7171
pipe.stop();
7272
}
7373

74-
protected void finalize() {
75-
dispose();
76-
}
7774
}

test/org/freedesktop/gstreamer/lowlevel/GValueTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@ private void testGValueArray(GValueArray gva) throws Exception {
9898
assertEquals("value mismatch", 5, gva.getValue(0));
9999
assertEquals("value mismatch", 5.0, gva.getValue(1));
100100
assertEquals("value mismatch", "omanipadmihoom", gva.getValue(2));
101+
102+
gva.free();
101103
}
102104

103105
@Test public void testInitSet() throws Exception {

0 commit comments

Comments
 (0)