change structure of the FileSystem interface

Author: git-growthdev

src/Behavioral/Command/OpenFileCommand.php

@@ -10,15 +10,13 @@ final class OpenFileCommand implements Command
 {
  private FileSystem $fileSystem;
 
- public function __construct(
- FileSystem $fileSystem,
- private string $fileName
- ) {
+ public function __construct(FileSystem $fileSystem)
+ {
  $this->fileSystem = $fileSystem;
  }
 
  public function execute(): void
  {
- $this->fileSystem->openFile($this->fileName);
+ $this->fileSystem->openFile();
  }
 }

src/Behavioral/Command/Receiver/FileSystem.php

@@ -6,7 +6,7 @@
 
 interface FileSystem
 {
- public function openFile(string $fileName): void;
+ public function openFile(): void;
  public function writeFile(string $content): void;
  public function closeFile(): void;
 }

src/Behavioral/Command/Receiver/UnixFileSystem.php

@@ -6,23 +6,21 @@
 
 final class UnixFileSystem implements FileSystem
 {
- private string $fileName;
+ private string $fileName = 'unix_file';
 
- public function openFile(string $fileName): void
+ public function openFile(): void
  {
- $this->fileName = $fileName;
-
- printf('Unix file %s is open' . PHP_EOL, $fileName);
+ printf('Unix file %s is open\n', $this->fileName);
  }
 
  public function writeFile(string $content): void
  {
- printf('Unix file %s is writing' . PHP_EOL, $this->fileName);
- printf('Content: %s' . PHP_EOL, $content);
+ printf('Unix file %s is writing\n', $this->fileName);
+ printf('Content: %s\n', $content);
  }
 
  public function closeFile(): void
  {
- printf('Unix file %s is closed' . PHP_EOL, $this->fileName);
+ printf('Unix file %s is closed\n', $this->fileName);
  }
 }

src/Behavioral/Command/Receiver/WindowsFileSystem.php

@@ -6,23 +6,21 @@
 
 final class WindowsFileSystem implements FileSystem
 {
- private string $fileName;
+ private string $fileName = 'windows_file';
 
- public function openFile(string $fileName): void
+ public function openFile(): void
  {
- $this->fileName = $fileName;
-
- printf('Windows file %s is open' . PHP_EOL, $fileName);
+ printf('Windows file %s is open\n', $this->fileName);
  }
 
  public function writeFile(string $content): void
  {
- printf('Windows file %s is writing' . PHP_EOL, $this->fileName);
+ printf('Windows file %s is writing\n', $this->fileName);
  printf('Content: %s' . PHP_EOL, $content);
  }
 
  public function closeFile(): void
  {
- printf('Windows file %s is closed' . PHP_EOL, $this->fileName);
+ printf('Windows file %s is closed\n', $this->fileName);
  }
 }

tests/Behavioral/Command/CommandTest.php

@@ -0,0 +1,29 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Growthdev\DesignPatterns\Tests\Behavioral\Command;
+
+use Growthdev\DesignPatterns\Behavioral\Command\FileInvoker;
+use Growthdev\DesignPatterns\Behavioral\Command\OpenFileCommand;
+use Growthdev\DesignPatterns\Behavioral\Command\Receiver\FileSystem;
+use Growthdev\DesignPatterns\Behavioral\Command\Receiver\UnixFileSystem;
+use Growthdev\DesignPatterns\Behavioral\Command\Receiver\WindowsFileSystem;
+use PHPUnit\Framework\TestCase;
+
+final class CommandTest extends TestCase
+{
+ private static function getFileSystem(): FileSystem
+ {
+ $os = strtoupper(substr(PHP_OS, 0, 3)) === 'LIN';
+
+ return $os ? new UnixFileSystem() : new WindowsFileSystem();
+ }
+
+ public function testCanInvokeFile(): void
+ {
+ $this->getFileSystem();
+
+ 
+ }
+}