feat: add switch to oneOf #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Preview is ready. |
Contributor
| Playwright Test Component is ready. |
bocembocem requested changes Sep 10, 2025
| ); | ||
| | ||
| const checkboxValue = React.useMemo(() => { | ||
| const isChecked = React.useMemo(() => { |
Collaborator
There was a problem hiding this comment.
The prefix "is" is typical for function naming, you can think of functions as questions, calling a function is basically the same as asking "Is checked?". Variable is more like a statement — "checked" is either yes or no, there’s no question involved here
In fact, in this case, changing the name doesn’t look critical, so I would suggest leaving it as it was.
bocembocem approved these changes Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.