Skip to content

Commit 99d84bc

Browse files
authored
Merge pull request #212 from graphql-dotnet/fix/issue-211
Loosen up return type constraint for DeriveTypeFromTypeInfo (fix #211)
2 parents 77a2cbc + 5841294 commit 99d84bc

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

.github/workflows/dotnetcore.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ jobs:
2727
run: |
2828
dotnet pack -c Release
2929
30-
- name: Install NuGet client
31-
uses: warrenbuckley/Setup-Nuget@v1
32-
33-
- name: Add private GitHub registry to NuGet
34-
run: |
35-
nuget sources add -name "GPR" -Source https://nuget.pkg.github.com/graphql-dotnet/index.json -Username tlil -Password ${{ secrets.GITHUB_TOKEN }}
36-
37-
- name: Push generated package to GitHub registry
38-
run: |
39-
dir src\GraphQL.Conventions\bin\Release\*.nupkg
40-
nuget push src\GraphQL.Conventions\bin\Release\*.nupkg -Source "GPR" -SkipDuplicate
30+
# - name: Install NuGet client
31+
# uses: warrenbuckley/Setup-Nuget@v1
32+
#
33+
# - name: Add private GitHub registry to NuGet
34+
# run: |
35+
# nuget sources add -name "GPR" -Source https://nuget.pkg.github.com/graphql-dotnet/index.json -Username tlil -Password ${{ secrets.GITHUB_TOKEN }}
36+
#
37+
# - name: Push generated package to GitHub registry
38+
# run: |
39+
# dir src\GraphQL.Conventions\bin\Release\*.nupkg
40+
# nuget push src\GraphQL.Conventions\bin\Release\*.nupkg -Source "GPR" -SkipDuplicate

src/GraphQL.Conventions/Adapters/GraphTypeAdapter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,14 @@ public void RegisterScalarType<TType>(string name)
6666
_registeredScalarTypes.Add(name, typeof(TType));
6767
}
6868

69-
private IGraphType DeriveTypeFromTypeInfo(Type type)
69+
private object DeriveTypeFromTypeInfo(Type type)
7070
{
7171
var graphType = _typeDescriptors.GetEntity(type);
7272
if (graphType != null)
7373
{
7474
return graphType;
7575
}
76-
return (IGraphType)Activator.CreateInstance(type);
76+
return Activator.CreateInstance(type);
7777
}
7878

7979
private IObjectGraphType DeriveOperationType(GraphTypeInfo typeInfo) =>

0 commit comments

Comments
 (0)