feat(GitHub Integration): Keep GitHub auth cookie within the same session if the data source doesn't change (#535)

Author: ifrost

src/pages/ProfilesExplorerView/components/SceneExploreServiceFlameGraph/components/SceneFunctionDetailsPanel/components/GitHubContextProvider/GitHubContextProvider.tsx

@@ -17,6 +17,9 @@ type GitHubContextProviderProps = {
 
 export const nonce = generateNonce();
 
+// Keep the data source UID in session storage to reuse it if the page is refreshed
+const SESSION_DATA_SOURCE_KEY = `grafana-pyroscope-app.gitHubIntegration.dataSourceUid`;
+
 export function GitHubContextProvider({ dataSourceUid, children }: GitHubContextProviderProps) {
  const vcsClient = DataSourceProxyClientBuilder.build(dataSourceUid, VcsClient);
  const privateVcsClient = DataSourceProxyClientBuilder.build(dataSourceUid, PrivateVcsClient);
@@ -29,7 +32,11 @@ export function GitHubContextProvider({ dataSourceUid, children }: GitHubContext
  // when logged in and changing data source
  // TODO: provide a better way
  useEffect(() => {
- setSessionCookie('');
+ const gitHubIntegrationDataSourceUid = sessionStorage.getItem(SESSION_DATA_SOURCE_KEY);
+ if (gitHubIntegrationDataSourceUid !== dataSourceUid) {
+ setSessionCookie('');
+ sessionStorage.setItem(SESSION_DATA_SOURCE_KEY, dataSourceUid || '');
+ }
  }, [dataSourceUid]); // eslint-disable-line react-hooks/exhaustive-deps
 
  usePollGitHubPopup({ vcsClient, externalWindow, setExternalWindow, setSessionCookie, nonce });